Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Infra] Upgrade to Defender 2.0 #1278

Closed
ryscheng opened this issue Feb 29, 2024 · 5 comments
Closed

[Infra] Upgrade to Defender 2.0 #1278

ryscheng opened this issue Feb 29, 2024 · 5 comments
Assignees

Comments

@ryscheng
Copy link
Member

ryscheng commented Feb 29, 2024

What is it?

https://docs.openzeppelin.com/defender/v2/migration

The old Defender API is being deprecated on Jun 2024.
I’m hoping the changes don’t require too much work, but it seems like we have to do it…

CC @bitbeckers

@bitbeckers
Copy link
Contributor

Thanks! With the indexer and API we're building, I think management of the upgrades in Defender could suffice 🤔

@bitbeckers
Copy link
Contributor

Indexer will do full state indexing of allowlists, tokens and claims. The migration will be the upgrade flows of the Safes

@bitbeckers bitbeckers changed the title Upgrade to Defender 2.0 [Infra] Upgrade to Defender 2.0 Apr 8, 2024
@bitbeckers
Copy link
Contributor

@bitbeckers
Copy link
Contributor

@holkexyz my proposal is we move away from Defender as a whole:

  • Allowlist caching will be done by our indexer/supabase
  • The free tier got nerfed. We would be but on the paid tier for >$400/month because we want to admin the Safe for our contracts which would be OP, Base, Celo and soon ARB. https://www.openzeppelin.com/pricing
  • If we don't use the allowlist caching, we only want to have an interface to create, review and sign an upgrade proposal for our Safe. This can be a one-pager side-app just for our admin purposes.

All in all, I think it's not worth it to commit to Defender V2. I do see how it can be worth it to do it for 1 month just so we can first focus on all other migrations we're doing.

This one is my bad, as we would actually be using less I wasn't expecting that it'd be neither paid nor so expensive.

@bitbeckers bitbeckers self-assigned this May 24, 2024
@bitbeckers
Copy link
Contributor

Defender 2.0 maintains the contract upgrade flow, indexer caches allowlist state

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants