-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MARKETPLACE] Investigate weird signing issue #1317
Comments
Steps to reproduce:
|
@bitbeckers I'm failing to reproduce this. I've bypassed a number of failsafes by running locally and created a makerorder for a token owned by address A, signed by address B, and registered it with our backend. Fractional sale: It fails with a Direct sale, with splitting upon order creation: errors out with Direct sale, bypassing splitting by putting up a fraction directly: It fails in my browser with Deployment that allows for creating and registering invalidly signed orders. Would you agree we can close this for now, or do you want to investigate further? |
Diving into this transaction, as it was implied this was faulty Claimed to: Buyer: 0x42FbF4d890B4EFA0FB0b56a9Cc2c5EB0e07C1536 Query
gives
Order from the DB:
Gnosis safe logs: (at the bottom is the token being transfered to the safe address) Reconstructing timeline:
|
Which area(s) of Hypercerts are affected? (leave empty if unsure)
No response
To Reproduce
Look into siging issue where a 3rd user can execute for user 1's ask, with user 2's bid.
Describe the Bug
.
Expected Behavior
.
The text was updated successfully, but these errors were encountered: