Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why all 2-Letter TLDs are Valid? #38

Closed
derektom14 opened this issue Jul 17, 2014 · 1 comment
Closed

Why all 2-Letter TLDs are Valid? #38

derektom14 opened this issue Jul 17, 2014 · 1 comment
Assignees
Milestone

Comments

@derektom14
Copy link

I was getting some complaints using linkify that many things that clearly weren't links (like referencing files with short extensions) were being linkified. Investigating, I found that the regex included this for identifying top-level domains:
com|ca|co|edu|gov|net|org|dev|biz|cat|int|pro|tel|mil|aero|asia|coop|info|jobs|mobi|museum|name|post|travel|local|[a-z]{2}
Clearly the final [a-z]{2} is going to lead to many false positives, so why exactly is this part of the regex?

@nfrasser nfrasser self-assigned this Jul 17, 2014
@nfrasser nfrasser mentioned this issue Jan 2, 2015
30 tasks
@nfrasser nfrasser modified the milestone: 2.0 Jan 28, 2015
@nfrasser
Copy link
Collaborator

Fixed in #51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants