Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

解决重复key会导致在深度合并时将字符串转换成数组 #338

Merged
merged 9 commits into from
Aug 7, 2019

Conversation

breath-co2
Copy link
Contributor

解决重复key会导致在深度合并时将字符串转换成数组

@wenbinye
Copy link
Contributor

wenbinye commented Aug 6, 2019

建议在 Arr 加入通用深度合并方法,参考 yii ArrayHelper 的实现:
https://github.com/yiisoft/yii2/blob/master/framework/helpers/BaseArrayHelper.php#L117

*/
class ProviderConfigTest extends TestCase
{
public function testProviderConfigMerge()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

单测应该再加上更多的场景

@limingxinleo
Copy link
Member

@huangzhhui 再看看

@limingxinleo limingxinleo merged commit 88ad10b into hyperf:master Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants