-
-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a setter for header_table_size
#637
Comments
What would adding the setter do? The |
I'd want to expose that option through
I'm doing some research into HTTP2 based fingerprinting. Its mostly about the flexibility of being able to set that value at will. (And also other things, which would not really matter for the average user) I understand that adding something like this may not be in the scope of the project. |
That seems fair! |
I'd like to make a PR to uncomment the setter for
header_table_size
, found here:h2/src/frame/settings.rs
Lines 124 to 128 in 87969c1
When playing around with the setter I found out that connections would sometimes fail the following check, Since the decoder's size is never updated from the default
DEFAULT_SETTINGS_HEADER_TABLE_SIZE
.h2/src/hpack/decoder.rs
Lines 256 to 258 in 88b0789
Would this be the place to fix that?
The text was updated successfully, but these errors were encountered: