New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compilation is broken on nightly #327
Comments
The problem with |
That's ok, we can just fix the code triggering a warning (I disagree that it's an anti-pattern). |
The warnings are compatibility warnings. For instance:
So, "fixing" the code would mean switching to the dyn syntax, and that would break compatibility with rust<1.27. Allowing compatibility warnings (not all warnings) would keep the code compatible with both rust 1.20 and nightly. |
I think the new warning lint didn't exist in 1.20 either, so probably just need an |
Fixed by #329. |
Compilation using the latest nightly (1.37.0-nightly (17e62f77f 2019-07-01)) emits warnings, and this prevents compilation because of
#![deny(warnings)]
.The text was updated successfully, but these errors were encountered: