Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation is broken on nightly #327

Closed
lovasoa opened this issue Jul 2, 2019 · 5 comments
Closed

Compilation is broken on nightly #327

lovasoa opened this issue Jul 2, 2019 · 5 comments

Comments

@lovasoa
Copy link
Contributor

lovasoa commented Jul 2, 2019

Compilation using the latest nightly (1.37.0-nightly (17e62f77f 2019-07-01)) emits warnings, and this prevents compilation because of #![deny(warnings)].

@lovasoa
Copy link
Contributor Author

lovasoa commented Jul 2, 2019

The problem with #![deny(warnings)] is well explained here, together with working alternatives: https://github.com/rust-unofficial/patterns/blob/master/anti_patterns/deny-warnings.md

@seanmonstar
Copy link
Member

That's ok, we can just fix the code triggering a warning (I disagree that it's an anti-pattern).

@lovasoa
Copy link
Contributor Author

lovasoa commented Jul 2, 2019

The warnings are compatibility warnings. For instance:

error: trait objects without an explicit `dyn` are deprecated

So, "fixing" the code would mean switching to the dyn syntax, and that would break compatibility with rust<1.27. Allowing compatibility warnings (not all warnings) would keep the code compatible with both rust 1.20 and nightly.

@seanmonstar
Copy link
Member

I think the new warning lint didn't exist in 1.20 either, so probably just need an #[allow(warnings)] in the few places this happens. It's probably the extensions map, right?

@lovasoa lovasoa mentioned this issue Jul 2, 2019
@carllerche
Copy link
Collaborator

Fixed by #329.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants