Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for futures::io::AsyncRead/Write #2024

Closed
Licenser opened this issue Nov 25, 2019 · 3 comments
Closed

support for futures::io::AsyncRead/Write #2024

Licenser opened this issue Nov 25, 2019 · 3 comments

Comments

@Licenser
Copy link

Licenser commented Nov 25, 2019

It seems that hyper uses tokio's AsyncRead / Write trait not the futures-0.3 one which makes it hard to mix with other libraries - would it be possible to implement both of the traits for hyper?

For context: I'm trying to upgrade a http connection to a websocket connection using async-tungstenite

@davidbarsky
Copy link
Contributor

I don't think this will happen happen for a bit. For additional details, see: tokio-rs/tokio#1744.

If I recall correctly, there is a crate that provides compatibility between Tokio's AsyncRead/Write and Futures' AsyncRead/Write, but I can't seem to find it right now.

@Licenser
Copy link
Author

No worries I gave up and put the web server on its own port, in fortunate that I can do that right now. There are more issues like different runtimes that make it impossible even when working around this. I’ll just go back to my cave for a few month and hope the Async ecosystem has stabilized in n something

@seanmonstar
Copy link
Member

Yea, as mentioned, the reason we're using Tokio's traits is because we'd like to consider alternative designs to the one proposed in futures-io.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants