Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the "raw" headers option in C API #2995

Closed
seanmonstar opened this issue Sep 23, 2022 · 0 comments
Closed

Remove the "raw" headers option in C API #2995

seanmonstar opened this issue Sep 23, 2022 · 0 comments
Labels
A-ffi Area: ffi (C API) C-refactor Category: refactor. This would improve the clarity of internal code. E-easy Effort: easy. A task that would be a great starting point for a new contributor.

Comments

@seanmonstar
Copy link
Member

The C API grew a concept of asking for the "raw" headers, but it turned out to not be useful in practice. We should remove them now while the API is still unstable.

  • Remove hyper_clientconn_options_headers_raw().
  • Remove hyper_response_headers_raw()
  • Delete the now unused code in client and proto.
  • Don't forget to run capi/gen_header.sh to sync up the hyper.h file.
@seanmonstar seanmonstar added E-easy Effort: easy. A task that would be a great starting point for a new contributor. C-refactor Category: refactor. This would improve the clarity of internal code. A-ffi Area: ffi (C API) labels Sep 23, 2022
@kentakang kentakang mentioned this issue Sep 26, 2022
Open
3 tasks
@dannasman dannasman mentioned this issue Oct 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-ffi Area: ffi (C API) C-refactor Category: refactor. This would improve the clarity of internal code. E-easy Effort: easy. A task that would be a great starting point for a new contributor.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@seanmonstar