feat(client): add 1.0 compatible client conn API #3155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanmonstar
force-pushed
the
3063-backports
branch
from
51b339f
to
99b76f7
Compare
oddgrd
reviewed
Mar 3, 2023
Comment on lines
+2322
to
+2331
| struct TokioExec; | ||
| impl<F> hyper::rt::Executor<F> for TokioExec | ||
| where | ||
| F: std::future::Future + Send + 'static, | ||
| F::Output: Send + 'static, | ||
| { | ||
| fn execute(&self, fut: F) { | ||
| tokio::spawn(fut); | ||
| } | ||
| } |
There was a problem hiding this comment.
Nit: should we move this outside the test (but inside the backports test module)?
seanmonstar
force-pushed
the
3063-backports
branch
from
fc45467
to
3d41ee1
Compare
This patch backports client/conn/http1 and http2 modules from 1.0 to ease transition. It allows code still using 0.14.x to switch to the per-version Connection types available in 1.0.
seanmonstar
force-pushed
the
3063-backports
branch
from
3d41ee1
to
3e08efc
Compare
This was referenced Mar 6, 2023
oddgrd
pushed a commit
to oddgrd/hyper
that referenced
this pull request
Mar 7, 2023
This patch backports client/conn/http1 and http2 modules from 1.0 to ease transition. It allows code still using 0.14.x to switch to the per-version Connection types available in 1.0. Closes hyperium#3053 Co-authored-by: KOVACS Tamas <ktamas@fastmail.fm>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch backports client/conn/http1 and http2 modules from 1.0 to ease transition. It allows code still using 0.14.x to switch to the per-version Connection types available in 1.0.
Updating (part of) #3063