Feat: Probing with Queue #1214
Closed
Feat: Probing with Queue #1214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennypradipta
requested review from
nicnocquee,
sapiderman,
raosan,
haricnugraha and
kevinhermawan
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1214 +/- ##
==========================================
+ Coverage 63.67% 63.70% +0.03%
==========================================
Files 111 111
Lines 3207 3210 +3
Branches 544 544
==========================================
+ Hits 2042 2045 +3
Misses 990 990
Partials 175 175 ☔ View full report in Codecov by Sentry. |
|
Could you elaborate more on the differences before and after implementing the queue? I think you could achieve the same result by removing the setTimeout function. |
lukman7788
approved these changes
Dec 19, 2023
ilmiawan
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Monika Pull Request (PR)
What feature/issue does this PR add
This PR fixes #980
How did you implement / how did you fix it
Even though we did not use Bree or Piscina as it is too much effort to refactor, I tried to do a POC using https://www.npmjs.com/package/queue to queue the probing functions.
Supposedly there are 800 probes, when it is time to probe, it will be queued.
How to test
Run Monika with Symon Mode