Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement WarpCrudModule update(WarpConfig) with HookConfig #3953

Open
ltyu opened this issue Jun 12, 2024 · 0 comments
Open

Implement WarpCrudModule update(WarpConfig) with HookConfig #3953

ltyu opened this issue Jun 12, 2024 · 0 comments

Comments

@ltyu
Copy link
Contributor

ltyu commented Jun 12, 2024

Blocked by:

Instead of removing HypERC20Deployer, we keep it continue to maintain it with the intent of eventually deprecating

Concretely:

  • When creating, just deploy the contracts necessary
  • When updating, read the existing on-chain config and:
    • Use Read default/required Hook to compare HookConfig, Create Hook if config does not match, and setHook

May reuse pieces of #3575 (e.g. the hook and ISM setting logic)

Related CLI Issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Sprint
Development

No branches or pull requests

1 participant