This repository has been archived by the owner on May 13, 2022. It is now read-only.

[Consensus] Unfork Tendermint pubsub #1074

Closed

silasdavis opened this issue Mar 18, 2019 · 1 comment

Labels

area/consensus area/gateway

Contributor

silasdavis commented Mar 18, 2019 •

edited

Tendermint have fixed the issues with blocking that caused me to fork their implementation (described here: tendermint/tmlibs#153) with:

tendermint/tendermint#3227 (released with Tendermint 0.31.0)

Other changes look like a modest improvement over what we have so suggest we unfork event/pubsub

compleatang changed the title ~~Unfork Tendermint pubsub~~ [Consensus] Unfork Tendermint pubsub

compleatang added area/consensus area/gateway labels

compleatang closed this as completed

Contributor Author

silasdavis commented Feb 1, 2021

We actually have slightly divergent needs for pubsub (we'd rather not block in all cases) and this code is fairly stable and light on maintenance

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.