Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use only the private key in gitops rather than configuring both the password and the private key #876

Closed
sivaramsk opened this issue Jul 24, 2020 · 3 comments · Fixed by #1439
Assignees
Labels
enhancement New feature or request good-first-issue Good for newcomers help wanted Extra attention is needed shared Related to code shared by all platforms
Projects

Comments

@sivaramsk
Copy link
Contributor

sivaramsk commented Jul 24, 2020

Is your feature request related to a problem? Please describe.
No

Describe the solution you'd like
In git-ops configuration, users configure the private_key which has write access to the repo. Why not use the private_key itself rather than requiring the user to configure the password as well.

Changes needed:

  1. Update the ansible role platforms/shared/configuration/roles/git_push to use git ssh given a choice. (add a choice parameter in network yaml)
  2. The changes should not break existing code i.e. current set-up of using https should also exist and work as it does now.
  3. Use the private_key from network.yaml for authentication.
  4. Test the complete set-up of at least one platform.
@sivaramsk sivaramsk added the enhancement New feature or request label Jul 24, 2020
@sownak sownak added the shared Related to code shared by all platforms label Jul 27, 2020
@sownak
Copy link
Contributor

sownak commented Jul 27, 2020

Feature request to enable git_push using SSH rather than https, as the private key is already supplied.

@sownak sownak added good-first-issue Good for newcomers help wanted Extra attention is needed labels Aug 12, 2020
@blockchainmonk
Copy link

i'll be happy to support if there is guide to get me started here. I am good with Hyperledger Fabric and have some experience with Corda too.

@sownak
Copy link
Contributor

sownak commented Sep 10, 2020

@blockchainmonk This task is more about Ansible and git than Fabric/Corda. The ansible role platforms/shared/configuration/roles/git_push uses git https to checkin; In this task this needs to be changed to use ssh and the given ssh key.
I have updated the main description as well.

@suvajit-sarkar suvajit-sarkar added this to To do in Sprint 39 Apr 26, 2021
@sownak sownak moved this from To do to In progress in Sprint 39 Apr 30, 2021
@sownak sownak linked a pull request May 4, 2021 that will close this issue
@sownak sownak moved this from In progress to Review in progress in Sprint 39 May 4, 2021
@sownak sownak closed this as completed May 4, 2021
Sprint 39 automation moved this from Review in progress to Done May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good-first-issue Good for newcomers help wanted Extra attention is needed shared Related to code shared by all platforms
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants