Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define and implement FSC performance metrics #337

Open
mbrandenburger opened this issue Aug 2, 2022 · 2 comments
Open

Define and implement FSC performance metrics #337

mbrandenburger opened this issue Aug 2, 2022 · 2 comments

Comments

@mbrandenburger
Copy link
Member

mbrandenburger commented Aug 2, 2022

This task is about starting a discussion on defining and implementing FSC performance metrics.
FSC comes with support for prometheus (https://github.com/hyperledger-labs/fabric-smart-client/blob/main/platform/view/services/metrics/operations/metrics.go).

Currently FSC reports the following:

  • Commiter:
    • commit
    • isFinal
    • listenTo

What about others?

  • View invocations via view manager
  • View interactions message size
  • Vault usage (size, read/write per sec)
  • KVS usage (size, read/write per sec)
  • Memory / CPU load
@davidkel
Copy link
Contributor

davidkel commented Aug 2, 2022

Given my lack of knowledge of the FSC at this time, the only comment I can currently make is that I don't think we need to worry too much about Memory/CPU Load at this time. We can leave it for other metrics gatherers to collect that information (eg prometheus process explorer, nmon, prometheus k8s).

@davidkel
Copy link
Contributor

davidkel commented Aug 2, 2022

Also FSC collects counter metrics on grpc connections opened and closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants