Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring integration test #483

Open
mbrandenburger opened this issue Jul 11, 2023 · 1 comment
Open

Refactoring integration test #483

mbrandenburger opened this issue Jul 11, 2023 · 1 comment

Comments

@mbrandenburger
Copy link
Member

mbrandenburger commented Jul 11, 2023

Many integration tests currently have redundant configurations via topology.go. While redundant code is not always bad, some code, in particular, the registration of the views could be reused among those tests.

This will help to maintain the tests, simplify the topology and thereby highlight what actual differences between the different integration tests.

@adecaro do you think it would make sense here to refactor this topology so we can re-use the view configuration in multiple integration tests?

I would assume that most of the views we are attaching to alice, bob, and co are the same. This would allow us to highlight better the actual configuration change in this topo, namely, adding two TMSs ... Maybe this could be handled in a separate PR. WDYT?

Originally posted by @mbrandenburger in #476 (comment)

@adecaro
Copy link
Contributor

adecaro commented Sep 5, 2023

Hi @mbrandenburger , do you mean to have a single topology for all the tests we run?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants