Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retry Proposal- and UpdateReponder Accept/Reject #25

Open
ggwpez opened this issue Mar 11, 2021 · 0 comments
Open

Retry Proposal- and UpdateReponder Accept/Reject #25

ggwpez opened this issue Mar 11, 2021 · 0 comments
Projects
Priority

Comments

@ggwpez
Copy link
Contributor

ggwpez commented Mar 11, 2021

The Accept and Reject functions of ProposalResponder and UpdateResponder can only be called once and panic on a second call.
I think this logic should only apply in the success case, since when an error occurs, the user probably wants to retry it without panic.
@ggwpez ggwpez linked a pull request Mar 11, 2021 that will close this issue
🔥 Remove gitlab issue templates. #24
Merged
@ggwpez ggwpez self-assigned this Mar 11, 2021
@matthiasgeihs matthiasgeihs reopened this Mar 17, 2021
@ggwpez ggwpez removed a link to a pull request Mar 17, 2021
🔥 Remove gitlab issue templates. #24
Merged
@ggwpez ggwpez removed their assignment Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Priority
Awaiting triage
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ggwpez @matthiasgeihs