Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error level logs should be printed by default #64

Closed
matthiasgeihs opened this issue May 5, 2021 · 1 comment · Fixed by #66
Closed

Error level logs should be printed by default #64

matthiasgeihs opened this issue May 5, 2021 · 1 comment · Fixed by #66
Labels
bug Something isn't working enhancement Improvement of an existing feature

Comments

@matthiasgeihs
Copy link
Contributor

It seems like if no logger is set up, runtime errors happening in the backend are not visible. This is problematic because relevant information might be hidden from a user. For example, when the funder fails to perform a channel funding operation, the user will just see "did not fund channel in time", while the logger actually has some more information "out of gas" or "failed to increase allowance".

I suggest that we make such error level logs visible to the user by default, for example, by printing them to stdout if no logger is set.

@matthiasgeihs matthiasgeihs added bug Something isn't working enhancement Improvement of an existing feature labels May 5, 2021
@ggwpez
Copy link
Contributor

ggwpez commented May 5, 2021

I like the idea. I set the default log level in the client package to warn now.
After testing it with the tutorial app, this seems to print funding errors. Maybe you can also test it?
Code is in #66

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement Improvement of an existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants