Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Funder interface #72

Closed
matthiasgeihs opened this issue May 13, 2021 · 0 comments · Fixed by #74
Closed

Simplify Funder interface #72

matthiasgeihs opened this issue May 13, 2021 · 0 comments · Fixed by #74
Labels
enhancement Improvement of an existing feature

Comments

@matthiasgeihs
Copy link
Contributor

It is currently rather complicated to setup a funder.

The constructor NewFunder takes as input accounts map[Asset]accounts.Account and depositors map[Asset]Depositor, both mapping from the same list of assets to a set of objects. For ease of use, these two maps could be combined into one map by integrating the account into the depositor.

Furthermore, there are no constructors for these maps and not much documentation on NewFunder, so it is hard to know how exactly the maps should be created. For ease of use, we should extend the documentation of NewFunder and we should make it easier to create a depositor map, e.g., by adding a special type for it with respective helper methods.

@matthiasgeihs matthiasgeihs added the enhancement Improvement of an existing feature label May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement of an existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant