Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jackson serialize PrivateData EmptyList field to empty string #18

Merged

Conversation

jitendra62075
Copy link
Contributor

  • Currently, if the privateData list is empty , jackson outputs it as json array i.e "[]" , to keep it inline with chaincode_event empty privateData, it is made empty string.

Signed-off-by:Jitendra Das jitendra.das@walmartlabs.com

@jitendra62075 jitendra62075 requested a review from a team as a code owner March 24, 2022 15:04
Copy link
Member

@arsulegai arsulegai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run git commit --amend -s and remove the incorrectly copied sign off line.

- Currently, if the privateData list is empty , jackson outputs it as json array i.e "[]" , to keep it inline with other fields, hence made it as empty string.

Signed-off-by: Jitendra Das <jitendra.das0@walmart.com>
@jitendra62075
Copy link
Contributor Author

Please run git commit --amend -s and remove the incorrectly copied sign off line.

Done

@arsulegai arsulegai merged commit 8ed379f into hyperledger-labs:main Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants