Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(prism-agent): ATL-6269 improve connections OpenAPI doc #833

Merged
merged 7 commits into from Jan 9, 2024

Conversation

bvoiturier
Copy link
Contributor

Overview

Fixes ATL-6269

Checklist

My PR contains...

  • No code changes (changes to documentation, CI, metadata, etc.)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes
  • are not breaking changes
  • If yes to above: I have updated the documentation accordingly

Documentation

  • My changes do not require a change to the project documentation
  • My changes require a change to the project documentation
  • If yes to above: I have updated the documentation accordingly

Tests

  • My changes can not or do not need to be tested
  • My changes can and should be tested by unit and/or integration tests
  • If yes to above: I have added tests to cover my changes
  • If yes to above: I have taken care to cover edge cases in my tests

Signed-off-by: Benjamin Voiturier <benjamin.voiturier@iohk.io>
…able object

Signed-off-by: Benjamin Voiturier <benjamin.voiturier@iohk.io>
Signed-off-by: Benjamin Voiturier <benjamin.voiturier@iohk.io>
…ocumentation

Signed-off-by: Benjamin Voiturier <benjamin.voiturier@iohk.io>
…tion

Signed-off-by: Benjamin Voiturier <benjamin.voiturier@iohk.io>
Signed-off-by: Benjamin Voiturier <benjamin.voiturier@iohk.io>
Copy link

sonarcloud bot commented Jan 8, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

github-actions bot commented Jan 8, 2024

Integration Test Results

11 files  ±0  11 suites  ±0   2s ⏱️ ±0s
24 tests ±0  24 ✅ ±0  0 💤 ±0  0 ❌ ±0 
25 runs  ±0  25 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit a6e69c4. ± Comparison against base commit f77b796.

Copy link
Contributor

github-actions bot commented Jan 8, 2024

Unit Test Results

 85 files  ±0   85 suites  ±0   21m 20s ⏱️ +4s
713 tests ±0  705 ✅ ±0  8 💤 ±0  0 ❌ ±0 
719 runs  ±0  711 ✅ ±0  8 💤 ±0  0 ❌ ±0 

Results for commit a6e69c4. ± Comparison against base commit f77b796.

@yshyn-iohk
Copy link
Member

Good job, @bvoiturier!
Let's merge this PR and I will rebase&refactor mine based on it

@bvoiturier bvoiturier merged commit 614e811 into main Jan 9, 2024
11 checks passed
@bvoiturier bvoiturier deleted the docs/ATL-6269-improve-connections-openapi-doc branch January 9, 2024 13:37
shotexa pushed a commit that referenced this pull request Mar 6, 2024
Signed-off-by: Benjamin Voiturier <benjamin.voiturier@iohk.io>
shotexa pushed a commit that referenced this pull request Mar 6, 2024
Signed-off-by: Benjamin Voiturier <benjamin.voiturier@iohk.io>
Signed-off-by: Shota Jolbordi <shota.jolbordi@iohk.io>
shotexa pushed a commit that referenced this pull request Mar 18, 2024
Signed-off-by: Benjamin Voiturier <benjamin.voiturier@iohk.io>
Signed-off-by: Shota Jolbordi <shota.jolbordi@iohk.io>
shotexa pushed a commit that referenced this pull request Mar 18, 2024
Signed-off-by: Benjamin Voiturier <benjamin.voiturier@iohk.io>
Signed-off-by: Shota Jolbordi <shota.jolbordi@iohk.io>
shotexa pushed a commit that referenced this pull request Mar 18, 2024
Signed-off-by: Benjamin Voiturier <benjamin.voiturier@iohk.io>
Signed-off-by: Shota Jolbordi <shota.jolbordi@iohk.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants