Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement codegen for yul primitive expressions #752

Merged
merged 3 commits into from Apr 20, 2022
Merged

Implement codegen for yul primitive expressions #752

merged 3 commits into from Apr 20, 2022

Conversation

LucasSte
Copy link
Contributor

This PR implements the code generation for YUL primitive expressions. I also provided unity tests for the function I created.

@LucasSte
Implement codegen for yul primitive expressions
4c3406a 
Signed-off-by: Lucas Steuernagel <lucas.tnagel@gmail.com>
seanyoung
seanyoung approved these changes Apr 19, 2022
View reviewed changes
Copy link
Contributor

@seanyoung seanyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's more difficult to review a PR if does not add functionality, but it's a piece of unused code. It's harder to see how it will all fits together

@LucasSte LucasSte merged commit b352b43 into hyperledger:main Apr 20, 2022
@LucasSte LucasSte deleted the yul-primitives branch April 20, 2022 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanyoung seanyoung seanyoung approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LucasSte @seanyoung