Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename indy-credx to anoncreds #2

Closed
8 tasks
TimoGlastra opened this issue Nov 2, 2022 · 7 comments · Fixed by #14
Closed
8 tasks

Rename indy-credx to anoncreds #2

TimoGlastra opened this issue Nov 2, 2022 · 7 comments · Fixed by #14
Assignees

Comments

@TimoGlastra
Copy link
Member

We need to rename the indy-credx module to the anoncreds module

  • Rename indy-credx directory to anoncreds
  • Update Cargo.toml and remove indy terms, add anoncreds naming/terms
  • Rename impl_indy_object to impl_anoncreds_object
  • Rename impl_indy_object_from_json to impl_anoncreds_object_from_json
  • Rename IndyObject to AnonCredsObject
  • Rename AnyIndyObject to AnyAnonCredsObject
  • Rename IndyObjectId to AnonCredsObjectId
  • Rename IndyObjectList to AnonCredsObjectList
@dkulic
Copy link
Contributor

dkulic commented Nov 3, 2022

Looks like I cannot assign myself on this task.

@swcurran
Copy link
Member

swcurran commented Nov 3, 2022

You have an invitation to join the Hyperledger organization and/or become a maintainer. Once you accept that, you can assign the tasks, etc. Please check your email associated with your GitHub account.

@dkulic
Copy link
Contributor

dkulic commented Nov 3, 2022

Ah, sorry, it went to my other mail.

@dkulic dkulic self-assigned this Nov 3, 2022
@dkulic
Copy link
Contributor

dkulic commented Nov 4, 2022

I have also changed all function prefixes from credx_ to anoncreds_. Just to confirm if this is required?

I need help with these two attributes from Cargo.toml:

authors = ["Hyperledger Indy Contributors <indy@lists.hyperledger.org>"]
description = "Verifiable credential issuance and presentation for Hyperledger Indy (https://www.hyperledger.org/projects), which provides a distributed-ledger-based foundation for self-sovereign identity (https://sovrin.org)."

Not sure what to put there?

@TimoGlastra
Copy link
Member Author

Just to confirm if this is required?

Yes 👍

I would say something like the following (@swcurran feel free to amend):

authors = ["Hyperledger AnonCreds Contributors <anoncreds@lists.hyperledger.org>"]
description = "Verifiable credential issuance and presentation for Hyperledger AnonCreds (https://www.hyperledger.org/projects), which provides a foundation for self-sovereign identity."

@swcurran
Copy link
Member

swcurran commented Nov 4, 2022

Looks pretty good. Please change the landing page to ""https://www.hyperledger.org/use/anoncreds" and I'll make sure that gets created in the next few days.

Interesting idea for the authors -- seems like a reasonable idea.

@dkulic
Copy link
Contributor

dkulic commented Nov 4, 2022

I think this PR is ready for review. Do not know who to put for it?
#14

@dkulic dkulic linked a pull request Nov 4, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
3 participants