Integrate indy-utils into anoncreds #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berendsliedrecht
changed the title
berendsliedrecht
force-pushed
the
remove-indy-utils
branch
from
9a6df72
to
fae50a0
Compare
TimoGlastra
approved these changes
Jan 17, 2023
| /// TODO: this should not default to Ok(()) | ||
| pub trait Validatable { | ||
| fn validate(&self) -> Result<(), ValidationError> { | ||
| Ok(()) |
There was a problem hiding this comment.
Should we open an issue to not forget?
There was a problem hiding this comment.
Yeah probably. This was done in indy-credx for items that might get future validation (not 100% sure though). So we might be able to just remove the validation on objects that do not need validation.
berendsliedrecht
force-pushed
the
remove-indy-utils
branch
4 times, most recently
from
2fe3003
to
325c059
Compare
Signed-off-by: blu3beri <blu3beri@proton.me>
berendsliedrecht
force-pushed
the
remove-indy-utils
branch
from
325c059
to
cd70172
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #33
indy-utilspackage and merged the used packages within anoncreds to theutilsdirectory.data_types/anoncreds/...directory as the only data types we will have areanoncreds.Work funded by the Government of Ontario.
Signed-off-by: blu3beri blu3beri@proton.me