Creating a /multitenancy/wallet may ignore wallet_dispatch_type

[tdiesler]

When creating a sub-wallet with wallet_dispatch_type=default like this ...

2022-04-22 11:29:00 TRACE [org.hyperledger.aries.BaseClient] (main) - Request{method=POST, url=http://localhost:8031/multitenancy/wallet, headers=[X-API-Key:adminkey]}
2022-04-22 11:29:00 TRACE [org.hyperledger.aries.BaseClient] (main) - RequestBody
{
  "wallet_dispatch_type": "default",
  "wallet_key": "FaberKey",
  "wallet_name": "Faber",
  "wallet_type": "indy"
}

I get a response, which suggests that wallet_dispatch_type=base

2022-04-22 11:29:01 TRACE [org.hyperledger.aries.BaseClient] (main) - Response{protocol=http/1.1, code=200, message=OK, url=http://localhost:8031/multitenancy/wallet}
2022-04-22 11:29:01 TRACE [org.hyperledger.aries.BaseClient] (main) - ResposeBody
{
  "updated_at": "2022-04-22T09:29:00.573828Z",
  "wallet_id": "daccbc17-eb53-422c-beb5-c1687d7a19d4",
  "settings": {
    "wallet.type": "indy",
    "wallet.name": "Faber",
    "wallet.webhook_urls": [],
    "wallet.dispatch_type": "base",
    "wallet.id": "daccbc17-eb53-422c-beb5-c1687d7a19d4"
  },
  "created_at": "2022-04-22T09:29:00.573828Z",
  "key_management_mode": "managed",
  "token": "eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJ3YWxsZXRfaWQiOiJkYWNjYmMxNy1lYjUzLTQyMmMtYmViNS1jMTY4N2Q3YTE5ZDQifQ.J43mc6AFSbr2HqlmEE8io2-rryTOzP-8ppO4Pnxf79Q"
}

[swcurran]

@TimoGlastra or @ianco -- could I get an assessment on this one. Is this an urgent fix -- e.g. 0.7.4?

[swcurran]

Reminder about this one. Sorry to be a pain @TimoGlastra or @ianco .

[ianco]

If no webhooks are specified for the sub-wallet then it automatically uses base:

https://github.com/hyperledger/aries-cloudagent-python/blob/main/aries_cloudagent/multitenant/admin/routes.py#L296

If you specify default then you need to specify a webhook for the sub-wallet.

[swcurran]

So perhaps this is a docs issue? Basically the wallet was not configured correctly?

I'm going to mark this as closed so we don't forget, but please reopen for further discussion and ways to address this issue.

[tdiesler]

So wallet_dispatch_type only applies to webhooks and not to websocket events?

This issue may be related to ...

#1750 [Security] WebSocket clients can see all events from all sub-wallets