Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aries-cloudagent-python - how revocation works? #505

Closed
Shweta-hlf opened this issue May 13, 2020 · 9 comments
Closed

aries-cloudagent-python - how revocation works? #505

Shweta-hlf opened this issue May 13, 2020 · 9 comments

Comments

@Shweta-hlf
Copy link

Shweta-hlf commented May 13, 2020

Using open rest api demo,Bank agent has created cred_def_id using "support revocation=true" and then created new revocation-registry and update it into tails file and publish this to ledger.Now bank agent issues credential to customer.Credetial is saved into customer wallet with cred_Rev_id.Now Bank wants to revoke issued credential from Customer.but cred_rev_id is with customer credential.
How bank will get cred_Rev_id ?
AS /issue-credential/revoke api require rev_reg_id and cred_rev_id ?
Pls help out.
cred_rev_id

@swcurran
Copy link
Member

The Bank must save the ID somewhere that it decides. This is data that the Controller would save in a database -- it shouldn't be kept in the Bank's agent storage. Typically, it would be stored in the bank's account tracking system.

@Shweta-hlf
Copy link
Author

Thanks a lot Stephen for your quick reply....!!!
Here Cred_rev_id is auto incremented when credential issue.I am not able to customize with new value by using "cred_rev_id" or "revocation_id" while sending credential.

@sklump
Copy link
Contributor

sklump commented May 13, 2020

Cred rev id is not customizable. It is an index into a tails file.

@sklump
Copy link
Contributor

sklump commented May 13, 2020

The issuer agent generates the Revocation registry identifier with the revocation registry. It is not customizable either.

@swcurran
Copy link
Member

Not sure about this, but should the algorithm for selection of a credential be more complex than incrementing from one? E.g. are we potentially leaking metadata if we give out the indices in order.

I'm asking -- not sure. Obviously tracking gets much more difficult if we don't just increment through the registry.

@andrewwhitehead
Copy link
Member

We don't have a choice given the interface in the current indy-sdk. It could be something to look at in future revocation designs.

@sklump
Copy link
Contributor

sklump commented May 13, 2020

It is just an identifier. There is no reason why it should be anything other than an index. There is nothing wrong with an increment. Tails files are public, there is no sensitive data leaking here.

@swcurran
Copy link
Member

Closing this as answered.

@Shweta-hlf
Copy link
Author

Thanks a lot for your answer.Cred_Rev_Id is stored into holder wallet while issuer has revocation id (same as cred_rev_id) will get from /issue-credential/records.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants