This repository has been archived by the owner on Mar 27, 2024. It is now read-only.
Preparing JWS proof : include Proof Type in verification data? #1548
Comments
Type still exists in proof value |
sudeshrshetty
added a commit
to sudeshrshetty/aries-framework-go
that referenced
this issue
Apr 1, 2020
According to Linked Data Signatures specification for JSON-LD ("https://github.com/digitalbazaar/jsonld-signatures") proof value type shouldn't be exluded while calculating checksum of proof value. This problem was found while running signature verification tests with signatures created by other systems using 'Ed25519Signature2018'. - above specification may not apply for 'JsonWebSignature2020'. Created issue hyperledger-archives#1548 to address this issue. - closes hyperledger-archives#1549 Signed-off-by: sudesh.shetty <sudesh.shetty@securekey.com>
sudeshrshetty
added a commit
to sudeshrshetty/aries-framework-go
that referenced
this issue
Apr 1, 2020
According to Linked Data Signatures specification for JSON-LD ("https://github.com/digitalbazaar/jsonld-signatures") proof value type shouldn't be exluded while calculating checksum of proof value. This problem was found while running signature verification tests with signatures created by other systems using 'Ed25519Signature2018'. - above specification may not apply for 'JsonWebSignature2020'. Created issue hyperledger-archives#1548 to address this issue. - closes hyperledger-archives#1549 Signed-off-by: sudesh.shetty <sudesh.shetty@securekey.com>
kdimak
added a commit
to kdimak/aries-framework-go
that referenced
this issue
Apr 3, 2020
closes hyperledger-archives#1548 Signed-off-by: Dmitriy Kinoshenko <dkinoshenko@gmail.com>
kdimak
added a commit
to kdimak/aries-framework-go
that referenced
this issue
Apr 3, 2020
closes hyperledger-archives#1548 Signed-off-by: Dmitriy Kinoshenko <dkinoshenko@gmail.com>
talwinder50
pushed a commit
to talwinder50/aries-framework-go
that referenced
this issue
Apr 7, 2020
According to Linked Data Signatures specification for JSON-LD ("https://github.com/digitalbazaar/jsonld-signatures") proof value type shouldn't be exluded while calculating checksum of proof value. This problem was found while running signature verification tests with signatures created by other systems using 'Ed25519Signature2018'. - above specification may not apply for 'JsonWebSignature2020'. Created issue hyperledger-archives#1548 to address this issue. - closes hyperledger-archives#1549 Signed-off-by: sudesh.shetty <sudesh.shetty@securekey.com>
talwinder50
pushed a commit
to talwinder50/aries-framework-go
that referenced
this issue
Apr 7, 2020
closes hyperledger-archives#1548 Signed-off-by: Dmitriy Kinoshenko <dkinoshenko@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
https://github.com/hyperledger/aries-framework-go/blob/55fe9fad72dcc99eb06b6dc5cf1c55daae3fe4bb/pkg/doc/signature/proof/jws.go#L104
Unable to find it in RFC:
https://tools.ietf.org/html/rfc7797
https://w3id.org/security/v2
https://github.com/digitalbazaar/jsonld-signatures
The text was updated successfully, but these errors were encountered: