chore: aries-js-worker - didexchange edgeagent/router #1357
Conversation
llorllale
requested review from
sudeshrshetty,
troyronda,
rolsonquadras and
fqutishat
cmd/aries-js-worker/src/aries.js
Outdated
| }, | ||
| acceptInvitation: async function (text) { | ||
| return invoke(aw, pending, this.pkgname, "AcceptInvitation", text, "timeout while accepting invitation") | ||
| acceptInvitation: async function (connectionID) { |
There was a problem hiding this comment.
The accept invitation API takes optional public DID as well (https://github.com/hyperledger/aries-framework-go/blob/master/pkg/controller/command/didexchange/models.go#L86) along with connection ID.
There was a problem hiding this comment.
ok: renamed back to connectionID and added an optional publicDID arg
Signed-off-by: George Aristy <george.aristy@securekey.com>
| }, | ||
| acceptInvitation: async function (text) { | ||
| return invoke(aw, pending, this.pkgname, "AcceptInvitation", text, "timeout while accepting invitation") | ||
| acceptInvitation: async function (connectionID, publicDID="") { |
There was a problem hiding this comment.
As per my opinion, we should avoid using strict function args, because every time there is an update in command controller models we may have to come back here to make corresponding updates.
| aries.didexchange.receiveInvitation(invitation) | ||
| }) | ||
|
|
||
| it("Edge Agent validates that the connection's state is 'completed'", function(done) { |
There was a problem hiding this comment.
Are we going to have the .feature file for this step/scenario ?
There was a problem hiding this comment.
See my findings so far under the second point in #1238
There was a problem hiding this comment.
So short answer is - I couldn't make it work.
There was a problem hiding this comment.
ok. so, for now looks like we wont be able to reuse the steps.
closes #1330
didexchange.acceptInvitationfailsdidexchange.acceptInvitation/queryConnectionByIDnow accept a text argument and transform it to a properly built object that the wasm expectsSigned-off-by: George Aristy george.aristy@securekey.com