Skip to content
This repository has been archived by the owner on Mar 27, 2024. It is now read-only.

feat: Method for adding Credential Application data to a VP #3109

Conversation

DRK3
Copy link
Contributor

@DRK3 DRK3 commented Dec 16, 2021

Signed-off-by: Derek Trider Derek.Trider@securekey.com

- Added a method that adds Credential Application data to a VP based on a Credential Manifest.
- Added "https://identity.foundation/credential-manifest/application/v1" context to the embedded contexts.

Signed-off-by: Derek Trider <Derek.Trider@securekey.com>
@DRK3 DRK3 force-pushed the MethodToAddCredentialApplicationToPresentation branch from 146dd7c to 5ed92e4 Compare December 16, 2021 22:37
@codecov
Copy link

codecov bot commented Dec 16, 2021

Codecov Report

Merging #3109 (5ed92e4) into main (dba32f9) will increase coverage by 0.01%.
The diff coverage is 96.51%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3109      +/-   ##
==========================================
+ Coverage   88.77%   88.78%   +0.01%     
==========================================
  Files         307      307              
  Lines       40294    40377      +83     
==========================================
+ Hits        35770    35850      +80     
- Misses       3310     3312       +2     
- Partials     1214     1215       +1     
Impacted Files Coverage Δ
pkg/doc/cm/credentialapplication.go 94.36% <96.38%> (+1.28%) ⬆️
pkg/doc/cm/credentialfulfillment.go 86.36% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0879ff...5ed92e4. Read the comment docs.

@DRK3 DRK3 marked this pull request as ready for review December 16, 2021 22:45
@sudeshrshetty sudeshrshetty merged commit 642a9f0 into hyperledger-archives:main Dec 16, 2021
sudeshrshetty pushed a commit to sudeshrshetty/aries-framework-go that referenced this pull request Jan 22, 2022
…ger-archives#3109)

- Added a method that adds Credential Application data to a VP based on a Credential Manifest.
- Added "https://identity.foundation/credential-manifest/application/v1" context to the embedded contexts.

Signed-off-by: Derek Trider <Derek.Trider@securekey.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants