Skip to content
This repository has been archived by the owner on Mar 27, 2024. It is now read-only.

test: WACI Issuance BDD tests for Go SDK #3133

Merged
merged 1 commit into from
Jan 24, 2022
Merged

test: WACI Issuance BDD tests for Go SDK #3133

merged 1 commit into from
Jan 24, 2022

Conversation

DRK3
Copy link
Contributor

@DRK3 DRK3 commented Jan 20, 2022

Signed-off-by: Derek Trider Derek.Trider@securekey.com

@codecov
Copy link

codecov bot commented Jan 20, 2022 •
edited
Loading

Codecov Report

Merging #3133 (877b441) into main (3a89fcd) will not change coverage.
The diff coverage is n/a.

❗ Current head 877b441 differs from pull request most recent head 2c469e8. Consider uploading reports for the commit 2c469e8 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3133   +/-   ##
=======================================
  Coverage   88.76%   88.76%           
=======================================
  Files         307      307           
  Lines       40940    40940           
=======================================
  Hits        36342    36342           
  Misses       3352     3352           
  Partials     1246     1246

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49e59b0...2c469e8. Read the comment docs.

@DRK3 DRK3 force-pushed the WACIIssuanceGoSDKBDDTests branch 2 times, most recently from e3d719f to 86b623b Compare January 20, 2022 01:59
@DRK3 DRK3 marked this pull request as ready for review January 20, 2022 02:23
sudeshrshetty
sudeshrshetty reviewed Jan 20, 2022
View reviewed changes
test/bdd/pkg/waci/waci_issuance_sdk_steps.go Outdated
}

func (i *IssuanceSDKSteps) acceptProposalV3(issuerName string) error {
piid, _, err := i.getActionID(issuerName, false)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are not cross checking invitation ID here to co-relate the proposal with the invitation.

you may have to do the similar correlation for other steps too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added Invitation ID cross checking.

I believe the other steps don't need it, since I use PIID with the issue credential client to accept and continue through the protocol, but let me know if there's something else I missed.

@DRK3 DRK3 changed the title test: WACI Issuance BDD tests for Go SDK test: WIP: WACI Issuance BDD tests for Go SDK Jan 20, 2022
@DRK3 DRK3 changed the title test: WIP: WACI Issuance BDD tests for Go SDK WIP: test: WACI Issuance BDD tests for Go SDK Jan 20, 2022
@DRK3 DRK3 changed the title WIP: test: WACI Issuance BDD tests for Go SDK test: WACI Issuance BDD tests for Go SDK Jan 20, 2022
@DRK3 DRK3 force-pushed the WACIIssuanceGoSDKBDDTests branch 9 times, most recently from 5d7f826 to 5152387 Compare January 20, 2022 22:40
baha-ai
baha-ai approved these changes Jan 20, 2022
View reviewed changes
test/bdd/features/waci_issuance.feature Outdated
Then "Holder" accepts the offer and sends a Credential Application to the Issuer
And "Issuer" accepts the Credential Application and sends a credential to the Holder
Then "Holder" accepts the credential
And Holder checks that the expected credential was received in a Credential Fulfillment attachment
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: add \n here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

test/bdd/pkg/waci/issue_credential_attachments.json Outdated
}
}
}
]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: add \n here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

test/bdd/pkg/waci/offer_credential_attachments.json Outdated
}
}
}
]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: add \n here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

test/bdd/pkg/waci/request_credential_attachments.json Outdated
}
}
}
]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: add \n here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@DRK3 DRK3 force-pushed the WACIIssuanceGoSDKBDDTests branch 7 times, most recently from 9c2a0fa to ed48240 Compare January 21, 2022 17:31
@DRK3 DRK3 force-pushed the WACIIssuanceGoSDKBDDTests branch 3 times, most recently from dff7d83 to 649b7d5 Compare January 21, 2022 21:57
test: WACI Issuance BDD tests for Go SDK
2c469e8 
Signed-off-by: Derek Trider <Derek.Trider@securekey.com>
@fqutishat fqutishat merged commit 7753c86 into hyperledger-archives:main Jan 24, 2022
@DRK3 DRK3 mentioned this pull request Feb 1, 2022
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Moopli Moopli Moopli approved these changes

@fqutishat fqutishat fqutishat approved these changes

@baha-ai baha-ai baha-ai approved these changes

@sudeshrshetty sudeshrshetty sudeshrshetty approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@DRK3 @Moopli @fqutishat @baha-ai @sudeshrshetty