test: Enhancements to WACI issuance BDD tests #3138
Conversation
| @@ -70,6 +81,7 @@ func (i *IssuanceSDKSteps) SetContext(ctx *context.BDDContext) { | |||
| } | |||
|
|
|||
| // RegisterSteps registers the BDD test steps on the suite. | |||
| // Note that VC proofs are not checked in this test suite. | |||
There was a problem hiding this comment.
Should I also check VC proofs? (if so, I can do that in my next PR) @sudeshrshetty @rolsonquadras
There was a problem hiding this comment.
that's ok, but nice to have feature. If it can be quick then do it.
| return &credentialFulfillmentAttachment, nil | ||
| } | ||
|
|
||
| func generateCredentialFulfillmentProof() map[string]string { |
There was a problem hiding this comment.
Not sure if this is the best way to do this... let me know if there's something else I should do instead. Also let me know if did:orb is ok here.
Codecov Report
@@ Coverage Diff @@
## main #3138 +/- ##
=======================================
Coverage 88.78% 88.78%
=======================================
Files 307 307
Lines 41044 41044
=======================================
Hits 36441 36441
Misses 3356 3356
Partials 1247 1247
Continue to review full report at Codecov.
|
| @@ -0,0 +1,12 @@ | |||
| { | |||
There was a problem hiding this comment.
is it possible to move these files (and the others in the waci folder) to a testdata subdirectory like elsewhere in test/bdd/pkg ?
- Attachments are now generated on the fly using pre-defined Credential Manifest, Credential Application, and Credential Fulfillment objects. - Added constants to Credential Manifest package for attachment formats and contexts. Signed-off-by: Derek Trider <Derek.Trider@securekey.com>
DRK3
force-pushed
the
WACIIssuanceBDDTestGenerateAttachmentsOnTheFly
branch
from
8beb23d
to
06de3b5
Compare
| @@ -70,6 +81,7 @@ func (i *IssuanceSDKSteps) SetContext(ctx *context.BDDContext) { | |||
| } | |||
|
|
|||
| // RegisterSteps registers the BDD test steps on the suite. | |||
| // Note that VC proofs are not checked in this test suite. | |||
There was a problem hiding this comment.
that's ok, but nice to have feature. If it can be quick then do it.
Signed-off-by: Derek Trider Derek.Trider@securekey.com