feat: add did document support for alsoKnownAs #3277
Conversation
brownoxford
force-pushed
the
feature/did-document-aka
branch
from
ebf8825
to
7994f86
Compare
| @@ -1395,6 +1400,16 @@ func populateRawServices(services []Service, didID, baseURI string) []map[string | |||
| return rawServices | |||
| } | |||
|
|
|||
| func populateRawAlsoKnownAs(aka []string) []interface{} { | |||
There was a problem hiding this comment.
please add unit tests to validate aka value as per schema
There was a problem hiding this comment.
suggest you cover a few different IRI formats, such as:
did:example:123, https://social.example/username, urn:uuid:1231
There was a problem hiding this comment.
There was a problem hiding this comment.
@Baha-sk Unit tests added to doc_test.go
| "type": "array", | ||
| "items": { | ||
| "type": "string", | ||
| "format": "uri" |
There was a problem hiding this comment.
careful with the uri format.... test cases need to exist to cover this... make sure you are covering all of:
Codecov Report
@@ Coverage Diff @@
## main #3277 +/- ##
=======================================
Coverage 88.28% 88.28%
=======================================
Files 315 315
Lines 42658 42668 +10
=======================================
+ Hits 37659 37669 +10
Misses 3674 3674
Partials 1325 1325
Continue to review full report at Codecov.
|
Signed-off-by: Chris Abernethy <brownoxford@gmail.com>
brownoxford
force-pushed
the
feature/did-document-aka
branch
from
7994f86
to
6f14536
Compare
Signed-off-by: Chris Abernethy brownoxford@gmail.com
Title:
Add
alsoKnownAssupport to DID documentDescription:
Implement support for
alsoKnownAsDID document element as described in DID Core v1Summary:
Add
AlsoKnownAselement todid.Docand populate value indid.ParseDocument()Add
AlsoKnownAselement todid.rawDocand populate value indid.Doc.JSONBytes()Add
did.populateRawAlsoKnownAs()helper function to convertalsoKnownAsfrom[]stringto[]interface{}Add
alsoKnownAsto schemas used for DID Schema Validation