fix: do not send package via outdated session #1559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Niall Shaw <niall.shaw@absa.africa>
TimoGlastra
reviewed
Aug 29, 2023
| return Object.values(this.transportSessionTable).filter( | ||
| (session) => session?.connectionId === connectionId && session.type === 'WebSocket' | ||
| ) | ||
| } | ||
| } |
There was a problem hiding this comment.
Maybe we can limit it to one session per type and connection id? That way we don't have to add web socket specific logic?
There was a problem hiding this comment.
Yeah, I'm happy with that also. Bug was only found in WebSocket, that's why I made it this way, but happy to change :)
|
FYI - this bug was found using AFJ 0.3.3, so perhaps it is not relevant anymore, but I can't see why it wouldn't be. |
Signed-off-by: Niall Shaw <niall.shaw@absa.africa>
Codecov Report
@@ Coverage Diff @@
## main #1559 +/- ##
=======================================
Coverage 85.73% 85.73%
=======================================
Files 950 950
Lines 22745 22753 +8
Branches 3978 3981 +3
=======================================
+ Hits 19500 19508 +8
Misses 3060 3060
Partials 185 185
|
|
@TimoGlastra - adjusted for any type |
niall-shaw
changed the title
genaris
approved these changes
Aug 29, 2023
ericvergnaud
pushed a commit
to Pocket-Developers/aries-framework-javascript
that referenced
this pull request
Sep 15, 2023
…1559) Signed-off-by: Niall Shaw <niall.shaw@absa.africa> Signed-off-by: Eric Vergnaud <eric.vergnaud@wanadoo.fr>
genaris
pushed a commit
to genaris/credo-ts
that referenced
this pull request
Sep 22, 2023
…1559) Signed-off-by: Niall Shaw <niall.shaw@absa.africa> Signed-off-by: Ariel Gentile <gentilester@gmail.com>
auer-martin
pushed a commit
to auer-martin/aries-framework-javascript
that referenced
this pull request
Nov 15, 2023
…1559) Signed-off-by: Niall Shaw <niall.shaw@absa.africa> Signed-off-by: Martin Auer <martin.auer97@gmail.com>
amitpadmani-awts
pushed a commit
to ayanworks/aries-framework-javascript
that referenced
this pull request
Nov 29, 2023
* fix: listen to incoming messages on agent initialize not constructor (openwallet-foundation#1542) Signed-off-by: Niall Shaw <niall.shaw@absa.africa> * fix(cheqd): make cosmos payer seed optional (openwallet-foundation#1547) Signed-off-by: Timo Glastra <timo@animo.id> * fix: create message subscription first (openwallet-foundation#1549) Signed-off-by: Timo Glastra <timo@animo.id> * fix(transport): Use connection in WebSocket ID (openwallet-foundation#1551) * fix: priority sorting for didcomm services (openwallet-foundation#1555) Signed-off-by: Timo Glastra <timo@animo.id> * fix: bump missing dependencies version (openwallet-foundation#1557) Signed-off-by: Eric Vergnaud <eric.vergnaud@wanadoo.fr> * chore(release): v0.4.1 (openwallet-foundation#1548) Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * fix: do not send package via outdated session (openwallet-foundation#1559) Signed-off-by: Niall Shaw <niall.shaw@absa.africa> * build(deps): bump @types/indy-sdk from 1.16.26 to 1.16.27 (openwallet-foundation#1564) Signed-off-by: dependabot[bot] <support@github.com> * fix(cheqd): changed the name formatting to a encoded hex value (openwallet-foundation#1574) Signed-off-by: Tom Lanser <tom@animo.id> * build(deps): bump @cheqd/ts-proto from 2.2.0 to 2.2.2 (openwallet-foundation#1568) Signed-off-by: dependabot[bot] <support@github.com> * build(deps): bump @cosmjs/proto-signing from 0.31.0 to 0.31.1 (openwallet-foundation#1566) Signed-off-by: dependabot[bot] <support@github.com> * fix(core): remove node-fetch dependency (openwallet-foundation#1578) Signed-off-by: Ariel Gentile <gentilester@gmail.com> * fix: log and throw on WebSocket sending errors (openwallet-foundation#1573) Signed-off-by: Eric Vergnaud <eric.vergnaud@wanadoo.fr> * fix(oob): support oob with connection and messages (openwallet-foundation#1558) Signed-off-by: Timo Glastra <timo@animo.id> * feat: allow connection invitation encoded in oob url param (openwallet-foundation#1583) Signed-off-by: Ariel Gentile <gentilester@gmail.com> * fix: duplicate service ids in connections protocol (openwallet-foundation#1589) * fix: implicit invitation to specific service (openwallet-foundation#1592) Signed-off-by: Ariel Gentile <gentilester@gmail.com> * fix(askar): throw error if imported wallet exists (openwallet-foundation#1593) Signed-off-by: Ariel Gentile <gentilester@gmail.com> * fix: service validation in OOB invitation objects (openwallet-foundation#1575) Signed-off-by: Ariel Gentile <gentilester@gmail.com> * fix: update tsyringe for ts 5 support (openwallet-foundation#1588) Signed-off-by: Timo Glastra <timo@animo.id> * chore(release): v0.4.2 (openwallet-foundation#1591) Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * fix: save AnonCredsCredentialRecord createdAt (openwallet-foundation#1603) Signed-off-by: Ariel Gentile <gentilester@gmail.com> * feat: sped up lookup for revocation registries (openwallet-foundation#1605) Signed-off-by: wadeking98 <wkingnumber2@gmail.com> * build(deps): bump @types/express from 4.17.17 to 4.17.18 (openwallet-foundation#1596) Bumps [@types/express](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/express) from 4.17.17 to 4.17.18. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/express) --- updated-dependencies: - dependency-name: "@types/express" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump actions/checkout from 3 to 4 (openwallet-foundation#1599) Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v3...v4) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump amannn/action-semantic-pull-request from 5.2.0 to 5.3.0 (openwallet-foundation#1598) build(deps): bump amannn/action-semantic-pull-request Bumps [amannn/action-semantic-pull-request](https://github.com/amannn/action-semantic-pull-request) from 5.2.0 to 5.3.0. - [Release notes](https://github.com/amannn/action-semantic-pull-request/releases) - [Changelog](https://github.com/amannn/action-semantic-pull-request/blob/main/CHANGELOG.md) - [Commits](amannn/action-semantic-pull-request@v5.2.0...v5.3.0) --- updated-dependencies: - dependency-name: amannn/action-semantic-pull-request dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: abandon proof protocol if presentation fails (openwallet-foundation#1610) Signed-off-by: Timo Glastra <timo@animo.id> * feat!: upgrade shared components (openwallet-foundation#1606) * feat: update dockerfile to node 18 and sample mediator to askar (openwallet-foundation#1622) Signed-off-by: Ariel Gentile <gentilester@gmail.com> * feat(sd-jwt-vc): Module for Issuer, Holder and verifier (openwallet-foundation#1607) Signed-off-by: Berend Sliedrecht <blu3beri@proton.me> * feat(indy-vdr): ability to refresh the pool manually (openwallet-foundation#1623) Signed-off-by: wadeking98 <wkingnumber2@gmail.com> * build(deps): bump @babel/traverse from 7.21.4 to 7.23.2 (openwallet-foundation#1608) Signed-off-by: dependabot[bot] <support@github.com> * build(deps): bump uuid and @types/uuid (openwallet-foundation#1597) Signed-off-by: dependabot[bot] <support@github.com> * build(deps): use node's built-in fetch (openwallet-foundation#1631) Signed-off-by: Ariel Gentile <gentilester@gmail.com> * build(deps): bump react-devtools-core from 4.27.6 to 4.28.5 (openwallet-foundation#1630) Signed-off-by: dependabot[bot] <support@github.com> * build(deps): bump @mattrglobal/bbs-signatures from 1.1.0 to 1.3.1 (openwallet-foundation#1601) Signed-off-by: dependabot[bot] <support@github.com> * fix: some log messages (openwallet-foundation#1636) Signed-off-by: Timo Glastra <timo@animo.id> * feat: bump indy-vdr version (openwallet-foundation#1637) Signed-off-by: Ariel Gentile <gentilester@gmail.com> * fix(core): allow string for did document controller (openwallet-foundation#1644) Signed-off-by: Berend Sliedrecht <sliedrecht@berend.io> * feat(anoncreds): issue revocable credentials (openwallet-foundation#1427) Signed-off-by: Ariel Gentile <gentilester@gmail.com> * refactor(anoncreds)!: move supportRevocation to options (openwallet-foundation#1648) Signed-off-by: Timo Glastra <timo@animo.id> * refactor: move message-pickup directory (openwallet-foundation#1650) Signed-off-by: Ariel Gentile <gentilester@gmail.com> --------- Signed-off-by: Niall Shaw <niall.shaw@absa.africa> Signed-off-by: Timo Glastra <timo@animo.id> Signed-off-by: Eric Vergnaud <eric.vergnaud@wanadoo.fr> Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Tom Lanser <tom@animo.id> Signed-off-by: Ariel Gentile <gentilester@gmail.com> Signed-off-by: wadeking98 <wkingnumber2@gmail.com> Signed-off-by: Berend Sliedrecht <blu3beri@proton.me> Signed-off-by: Berend Sliedrecht <sliedrecht@berend.io> Co-authored-by: Niall Shaw <100220424+niall-shaw@users.noreply.github.com> Co-authored-by: Timo Glastra <timo@animo.id> Co-authored-by: Alexander Shenshin <93187809+AlexanderShenshin@users.noreply.github.com> Co-authored-by: ericvergnaud <eric.vergnaud@wanadoo.fr> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Tom Lanser <tommy.lanser@gmail.com> Co-authored-by: Ariel Gentile <gentilester@gmail.com> Co-authored-by: Wade King <wkingnumber2@gmail.com> Co-authored-by: Berend Sliedrecht <61358536+berendsliedrecht@users.noreply.github.com>
amitpadmani-awts
pushed a commit
to ayanworks/aries-framework-javascript
that referenced
this pull request
Nov 29, 2023
* fix: listen to incoming messages on agent initialize not constructor (openwallet-foundation#1542) Signed-off-by: Niall Shaw <niall.shaw@absa.africa> * fix(cheqd): make cosmos payer seed optional (openwallet-foundation#1547) Signed-off-by: Timo Glastra <timo@animo.id> * fix: create message subscription first (openwallet-foundation#1549) Signed-off-by: Timo Glastra <timo@animo.id> * fix(transport): Use connection in WebSocket ID (openwallet-foundation#1551) * fix: priority sorting for didcomm services (openwallet-foundation#1555) Signed-off-by: Timo Glastra <timo@animo.id> * fix: bump missing dependencies version (openwallet-foundation#1557) Signed-off-by: Eric Vergnaud <eric.vergnaud@wanadoo.fr> * chore(release): v0.4.1 (openwallet-foundation#1548) Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * fix: do not send package via outdated session (openwallet-foundation#1559) Signed-off-by: Niall Shaw <niall.shaw@absa.africa> * build(deps): bump @types/indy-sdk from 1.16.26 to 1.16.27 (openwallet-foundation#1564) Signed-off-by: dependabot[bot] <support@github.com> * fix(cheqd): changed the name formatting to a encoded hex value (openwallet-foundation#1574) Signed-off-by: Tom Lanser <tom@animo.id> * build(deps): bump @cheqd/ts-proto from 2.2.0 to 2.2.2 (openwallet-foundation#1568) Signed-off-by: dependabot[bot] <support@github.com> * build(deps): bump @cosmjs/proto-signing from 0.31.0 to 0.31.1 (openwallet-foundation#1566) Signed-off-by: dependabot[bot] <support@github.com> * fix(core): remove node-fetch dependency (openwallet-foundation#1578) Signed-off-by: Ariel Gentile <gentilester@gmail.com> * fix: log and throw on WebSocket sending errors (openwallet-foundation#1573) Signed-off-by: Eric Vergnaud <eric.vergnaud@wanadoo.fr> * fix(oob): support oob with connection and messages (openwallet-foundation#1558) Signed-off-by: Timo Glastra <timo@animo.id> * feat: allow connection invitation encoded in oob url param (openwallet-foundation#1583) Signed-off-by: Ariel Gentile <gentilester@gmail.com> * fix: duplicate service ids in connections protocol (openwallet-foundation#1589) * fix: implicit invitation to specific service (openwallet-foundation#1592) Signed-off-by: Ariel Gentile <gentilester@gmail.com> * fix(askar): throw error if imported wallet exists (openwallet-foundation#1593) Signed-off-by: Ariel Gentile <gentilester@gmail.com> * fix: service validation in OOB invitation objects (openwallet-foundation#1575) Signed-off-by: Ariel Gentile <gentilester@gmail.com> * fix: update tsyringe for ts 5 support (openwallet-foundation#1588) Signed-off-by: Timo Glastra <timo@animo.id> * chore(release): v0.4.2 (openwallet-foundation#1591) Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * chore: update yarn.lock Signed-off-by: Sai Ranjit Tummalapalli <sairanjit.tummalapalli@ayanworks.com> --------- Signed-off-by: Niall Shaw <niall.shaw@absa.africa> Signed-off-by: Timo Glastra <timo@animo.id> Signed-off-by: Eric Vergnaud <eric.vergnaud@wanadoo.fr> Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Tom Lanser <tom@animo.id> Signed-off-by: Ariel Gentile <gentilester@gmail.com> Signed-off-by: Sai Ranjit Tummalapalli <sairanjit.tummalapalli@ayanworks.com> Co-authored-by: Niall Shaw <100220424+niall-shaw@users.noreply.github.com> Co-authored-by: Timo Glastra <timo@animo.id> Co-authored-by: Alexander Shenshin <93187809+AlexanderShenshin@users.noreply.github.com> Co-authored-by: ericvergnaud <eric.vergnaud@wanadoo.fr> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Tom Lanser <tommy.lanser@gmail.com> Co-authored-by: Ariel Gentile <gentilester@gmail.com>
auer-martin
pushed a commit
to auer-martin/aries-framework-javascript
that referenced
this pull request
Dec 4, 2023
…1559) Signed-off-by: Niall Shaw <niall.shaw@absa.africa> Signed-off-by: Martin Auer <martin.auer97@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We found an edge-case where a websocket transport session would be closed/unavailable on the client agent side, but mediator still thinks it is available (due to client being offline).
When client returns back online and initiates a flow via mediator, the mediator will attempt to send the package to the now outdated websocket, instead of the newest / current session.
This PR fixes the problem, but is there any reason why a single connection may need multiple open WebSocket transport sessions?