Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for receiving and proving revocable indy credentials #349

Closed
Tracked by #112
TimoGlastra opened this issue Jul 3, 2021 · 12 comments · Fixed by #592
Closed
Tracked by #112

Add support for receiving and proving revocable indy credentials #349

TimoGlastra opened this issue Jul 3, 2021 · 12 comments · Fixed by #592
Assignees
Labels
AIP 1.0 Tasks related to AIP 1.0 support Indy Tasks related to Indy DIDs, credentials and ledgers Type: Enhancement
Milestone

Comments

@TimoGlastra
Copy link
Contributor

No description provided.

@TimoGlastra TimoGlastra added AIP 1.0 Tasks related to AIP 1.0 support Indy Tasks related to Indy DIDs, credentials and ledgers Type: Enhancement labels Jul 3, 2021
@TimoGlastra TimoGlastra added this to the AIP 1.0 milestone Jul 3, 2021
@TimoGlastra
Copy link
Contributor Author

@JamesKEbert assigning you. This is only the receiving and proving part. #112 tracks the whole flow

@swcurran
Copy link
Contributor

A reminder -- because it's been a pain.

  • A proof request that includes a revocation interval can be satisfied with a non-revocable credential.
  • A proof request that does not include a revocation interval can be satisfied with a revocable credential.

LISSI and estatus support this correctly, Trinisic still does not.

@JamesKEbert
Copy link
Contributor

@swcurran revocation intervals in Indy can be specified on an attribute/predicate basis, is this something generally supported by the community, or is it sufficient to use the proof request's top level revocation interval?

@swcurran
Copy link
Contributor

I'm not aware of anyone using them, but all of that is handled in the Indy SDK (or indy-shared-rs) and so should "just work" if the conventions are followed. See: https://github.com/hyperledger/aries-rfcs/tree/master/concepts/0441-present-proof-best-practices for what conventions are to be followed -- with the big thing being the from/to range to give the Indy proof request.

@TimoGlastra TimoGlastra modified the milestones: AIP 1.0, 0.1.0 Aug 20, 2021
@TimoGlastra
Copy link
Contributor Author

@JamesKEbert any updates on this?

@JamesKEbert
Copy link
Contributor

Hey @TimoGlastra, sorry for any delays here--IIW did throw off some my timelines a little. I'll be working on this today. :)

@TimoGlastra
Copy link
Contributor Author

Awesome -- thanks! :)

@TimoGlastra
Copy link
Contributor Author

@JamesKEbert what's the status of this? If you're not able to finish it, maybe you can post what's already there so someone else can pick it up?

@JamesKEbert
Copy link
Contributor

@TimoGlastra, sorry for any delays here--I actually have been making good progress on this, I expect to have a PR this week. I have a couple of things that might be good to discuss, so maybe during the AFJ call tomorrow some discussion time might be good?

@TimoGlastra
Copy link
Contributor Author

@JamesKEbert as part of the revocation work, are you also picking up the revocation notification protocol (#493)? There is someone else that might work on it, if you're not working on it already

@JamesKEbert
Copy link
Contributor

Yes, we are, we've only implemented the holder side of the protocol though. I figure when the efforts for the issuer-side happen we may be to a new iteration of the protocol anyways.

@TimoGlastra
Copy link
Contributor Author

That's great. Thanks James :)

@TimoGlastra TimoGlastra linked a pull request Feb 4, 2022 that will close this issue
6 tasks
@TimoGlastra TimoGlastra modified the milestones: 0.1.0, 0.2.0 Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AIP 1.0 Tasks related to AIP 1.0 support Indy Tasks related to Indy DIDs, credentials and ledgers Type: Enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants