Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make getRequestedCredentialsForProofRequest more in line with other methods #365

Closed
TimoGlastra opened this issue Jul 5, 2021 · 0 comments · Fixed by #523
Closed

make getRequestedCredentialsForProofRequest more in line with other methods #365

TimoGlastra opened this issue Jul 5, 2021 · 0 comments · Fixed by #523
Labels
Indy Tasks related to Indy DIDs, credentials and ledgers Type: Enhancement

Comments

@TimoGlastra
Copy link
Contributor

the getRequestedCredentialsForProofRequest in the proofs module currently expects an indy proof request as input. We should abstract such details away as much as possible.

Current

const retrievedCredentials = await aliceAgent.proofs.getRequestedCredentialsForProofRequest(
  indyProofRequest!,
  presentationPreview
)

Proposed

const retrievedCredentials = await aliceAgent.proofs.getRequestedCredentialsForProofRequest(
  proofRecord.id
)

OR below

but as modules mostly take ids I think the first is better. The service could then take a record.

const retrievedCredentials = await aliceAgent.proofs.getRequestedCredentialsForProofRequest(
  proofRecord
)
@TimoGlastra TimoGlastra added Type: Enhancement Indy Tasks related to Indy DIDs, credentials and ledgers labels Jul 5, 2021
@TimoGlastra TimoGlastra linked a pull request Nov 8, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Indy Tasks related to Indy DIDs, credentials and ledgers Type: Enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant