Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

serviceEndpoint not set when not providing mediatorConnectionsInvite to InitConfig #401

Closed
karimStekelenburg opened this issue Jul 21, 2021 · 3 comments
Assignees

Comments

@karimStekelenburg
Copy link
Contributor

This issue is probably related to #381

When I start my agent for the first time and pass the mediatorConnectionsInvite to the InitConfig, it successfully connects to the mediator and everything works fine. However, if I restart my agent with exactly the same InitConfig configuration, my application hangs at the agent.initialize() call.

I can resolve this by removing the mediatorConnectionsInvite param from the InitConfig, this will make the agent initialize successfully and reconnect to the mediator. However, because I'm not passing mediatorConnectionsInvite to the InitConfig, serviceEndpoint in the invitation that is returned from agent.connections.createConnection() is not set to the mediator url.

In other words: I can only get a valid invitation object at the first run. Thereafter any agent I pass the invitation object to won't know how to reach my agent.

In my view the agent should start without problems when mediatorConnectionsInvite is set, regardless of any existing mediator connections. I think @TimoGlastra's suggestion in #381 makes sense. Furthermore, I think the serviceEndpoint value inside the invitation shouldn't depend on the InitConfig, but should instead be based on a MediatorRecord (if any).

@TimoGlastra
Copy link
Contributor

@burdettadam could you take a look at this?

@burdettadam
Copy link
Contributor

Yes, I will take a look at this. I think I see the problem.

@TimoGlastra
Copy link
Contributor

Fixed in #419

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants