Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add multiple inbound transports #433

Conversation

TimoGlastra
Copy link
Contributor

  • add support for multiple inbound transports
  • rename all occurrences of transporter to transport

Signed-off-by: Timo Glastra <timo@animo.id>
@TimoGlastra TimoGlastra requested a review from a team as a code owner August 20, 2021 09:59
@codecov-commenter
Copy link

codecov-commenter commented Aug 20, 2021

Codecov Report

Merging #433 (14e9ab8) into main (87bc589) will increase coverage by 0.06%.
The diff coverage is 92.68%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #433      +/-   ##
==========================================
+ Coverage   85.60%   85.66%   +0.06%     
==========================================
  Files         249      249              
  Lines        5342     5351       +9     
  Branches      798      796       -2     
==========================================
+ Hits         4573     4584      +11     
+ Misses        769      767       -2     
Impacted Files Coverage Δ
.../core/src/modules/credentials/CredentialsModule.ts 88.46% <ø> (ø)
...les/credentials/handlers/OfferCredentialHandler.ts 65.51% <ø> (ø)
packages/core/src/modules/proofs/ProofsModule.ts 91.52% <ø> (ø)
...ules/proofs/handlers/RequestPresentationHandler.ts 94.11% <ø> (ø)
...re/src/modules/routing/services/MediatorService.ts 68.96% <ø> (ø)
packages/core/src/types.ts 100.00% <ø> (ø)
packages/core/src/agent/MessageSender.ts 71.42% <62.50%> (-0.51%) ⬇️
packages/core/src/agent/Agent.ts 96.90% <100.00%> (+2.22%) ⬆️
packages/core/src/agent/AgentConfig.ts 90.90% <100.00%> (ø)
packages/core/src/agent/MessageReceiver.ts 92.42% <100.00%> (+0.36%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87bc589...14e9ab8. Read the comment docs.

Signed-off-by: Timo Glastra <timo@animo.id>
Signed-off-by: Timo Glastra <timo@animo.id>
@TimoGlastra TimoGlastra linked an issue Aug 20, 2021 that may be closed by this pull request
@@ -20,8 +20,9 @@ export class WsInboundTransport implements InboundTransporter {

this.logger = config.logger

this.logger.debug(`Starting HTTP inbound transporter`, {
endpoint: config.getEndpoint(),
const httpEndpoint = config.endpoints.find((e) => e.startsWith('http'))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not the most knowledgeable on this subject, but this will also match https. Which might be intended but the log message below is incorrect then.

Copy link
Contributor

@JamesKEbert JamesKEbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Timo Glastra <timo@animo.id>
Signed-off-by: Timo Glastra <timo@animo.id>
@TimoGlastra TimoGlastra merged commit 56cb9f2 into openwallet-foundation:main Aug 21, 2021
@TimoGlastra TimoGlastra deleted the feat/multiple-inbound-transports branch October 28, 2021 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for multiple transports
6 participants