Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introductions and some context #43

Merged
merged 5 commits into from Jun 27, 2022

Conversation

anagoessens
Copy link
Contributor

@anagoessens anagoessens commented Jun 27, 2022

Hi everyone, I'm planning to do a larger PR to fill out the docs more, but wanted to make this smaller one to get some initial thoughts on writing style etc.

I'm also proposing to change the file names 'prerequisites' to 'installation' and 'installation' to 'set up' as it better reflects the written context. For example currently in the doc titled set up (but filename installation) it is said that "this guide assumes you have followed the install guides".

@anagoessens anagoessens force-pushed the documentation branch 2 times, most recently from fdb0e64 to f5166a4 Compare June 27, 2022 13:39
Copy link
Contributor

@TimoGlastra TimoGlastra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, looking forward to the follow up PRs!

@TimoGlastra
Copy link
Contributor

It seems CI is failing. Can you run yarn format locally?

Signed-off-by: Ana Goessens <ana@animo.id>
Signed-off-by: Ana Goessens <ana@animo.id>
Signed-off-by: Ana Goessens <ana@animo.id>
Signed-off-by: Ana Goessens <ana@animo.id>
Signed-off-by: Ana Goessens <ana@animo.id>
@TimoGlastra TimoGlastra enabled auto-merge (squash) June 27, 2022 21:38
@TimoGlastra TimoGlastra merged commit 2b3ea26 into openwallet-foundation:main Jun 27, 2022
@anagoessens anagoessens deleted the documentation branch June 27, 2022 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants