Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

walletName undefined causing errors during connections #871

Closed
3 of 5 tasks
bryce-mcmath opened this issue Jul 4, 2023 · 1 comment
Closed
3 of 5 tasks

walletName undefined causing errors during connections #871

bryce-mcmath opened this issue Jul 4, 2023 · 1 comment
Assignees

Comments

@bryce-mcmath
Copy link
Contributor

Description of problem

Older wallets running the latest build will overwrite the default value of walletName with undefined causing errors during connections due to the label missing

Expected behavior

The label should always be defined and the default value should not be overwritten with undefined during initialization

Steps to reproduce

Complete onboarding with an older version of the wallet (pre-wallet naming PR), then switch to the latest version without wiping your storage. After reloading, try to make a connection.

Screenshots and/or log output

Environment

  • Occurs on Android
  • Occurs on iOS

Build #: 998

Android Device Model:

iOS Device Model:

Workaround

N/A

Severity

  • High
  • Medium
  • Low
@bryce-mcmath bryce-mcmath self-assigned this Jul 4, 2023
@hiteshgh
Copy link

assigned back to @bryce-mcmath to confirm if bug is fixed, if yes mark as closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants