Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(oca): attribute_categories should not be required #945

Closed
cvarjao opened this issue Aug 30, 2023 · 1 comment · Fixed by #950
Closed

bug(oca): attribute_categories should not be required #945

cvarjao opened this issue Aug 30, 2023 · 1 comment · Fixed by #950
Assignees
@amanji
Labels
bug Something isn't working

Comments

@cvarjao
Copy link
Contributor

cvarjao commented Aug 30, 2023

As per OCA spec, attribute_categories is optional.

https://github.com/hyperledger/aries-mobile-agent-react-native/blob/e83ae93fa42fbb96ad4a805195323d31d1436b5f/packages/oca/src/interfaces/data/semantic/LabelOverlayData.interface.ts#L6C5-L6C5
@amanji amanji self-assigned this Aug 31, 2023
@amanji amanji added the bug Something isn't working label Aug 31, 2023
@amanji
Copy link
Contributor

amanji commented Aug 31, 2023

Confirmed. Will make optional.

@amanji amanji mentioned this issue Aug 31, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amanji amanji

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: oca interfaces petridishdev/bifold-wallet
2 participants
@cvarjao @amanji