Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjust safeareaview and remove unneeded styles #1056

Conversation

bryce-mcmath
Copy link
Contributor

Summary of Changes

Fixes button placement on verifier proof requesting screen. See below

Old:
proof_requesting_old

New:
proof_requesting_new

Related Issues

N/A

Pull Request Checklist

Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.

  • All commits contain a DCO Signed-off-by line (we use the DCO GitHub app to enforce this);
  • Updated LICENSE-3RD-PARTY.md for any added dependencies or vendored components;
  • Updated documentation as needed for changed code and new or modified features;
  • Added sufficient tests so that overall code coverage is not reduced.

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

Pro Tip 🤓

  • Read our contribution guide at least once; it will save you a few review cycles!
  • Your PR will likely not be reviewed until all the above boxes are checked and all automated tests have passed.

PR template adapted from the Python attrs project.

Signed-off-by: Bryce McMath <bryce.j.mcmath@gmail.com>
@bryce-mcmath bryce-mcmath marked this pull request as ready for review January 3, 2024 21:24
@bryce-mcmath bryce-mcmath requested a review from a team as a code owner January 3, 2024 21:24
Copy link

codecov bot commented Jan 3, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (79c1e53) 61.52% compared to head (e6447b7) 61.52%.

Files Patch % Lines
...ckages/legacy/core/App/screens/ProofRequesting.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1056   +/-   ##
=======================================
  Coverage   61.52%   61.52%           
=======================================
  Files         170      170           
  Lines        5456     5456           
  Branches     1570     1570           
=======================================
  Hits         3357     3357           
  Misses       2075     2075           
  Partials       24       24           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bryce-mcmath bryce-mcmath merged commit 1317246 into openwallet-foundation:main Jan 3, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants