New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Post install script for installing Indy binary dependencies for Android #139
Post install script for installing Indy binary dependencies for Android #139
Conversation
Signed-off-by: Clécio Varjão <1348549+cvarjao@users.noreply.github.com>
@@ -11,7 +11,8 @@ | |||
"test": "jest", | |||
"lint": "eslint --ignore-path .gitignore --ext .js,.jsx,.ts,.tsx --color .", | |||
"prettier": "prettier --ignore-path .gitignore '**/*.+(js|jsx|json|ts|tsx|md|yml|yaml)'", | |||
"postinstall": "patch-package", | |||
"prepack": "rimraf *.tgz", | |||
"postinstall": "patch-package && node post-install-setup.js", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will run after every install right? Maybe you can add some form of check to see if this setup has already be done, that way on multiple runs it will actually only run once
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that can be optimized for sure. I am assuming npm install
or npm ci
is not something that developer runs very frequently, so I didn't think the overhead was too much. I've added to the existing postinstall, since I am not sure what patch-package
is used for. I will add some extra checks to allow for caching
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
patch-package
is used for patching files in the node_modules
directory (see patches
directory)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm curious to hear a bit more about your setup. Are you consuming bifold as a library? How would that work? Do you import files/components from this package?
The bootstrapping workflow that I am thinking does something like:
The generated/default index.js will looks something like:
|
Signed-off-by: Clécio Varjão <1348549+cvarjao@users.noreply.github.com>
@TimoGlastra, here is a crude idea of what I am thinking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't tested, but otherwise LGTM.
I'm still in favour of not adding this for the main repo as it complicates setup, but fine with merging.
@JamesKEbert what are your thoughts?
@@ -11,7 +11,8 @@ | |||
"test": "jest", | |||
"lint": "eslint --ignore-path .gitignore --ext .js,.jsx,.ts,.tsx --color .", | |||
"prettier": "prettier --ignore-path .gitignore '**/*.+(js|jsx|json|ts|tsx|md|yml|yaml)'", | |||
"postinstall": "patch-package", | |||
"prepack": "rimraf *.tgz", | |||
"postinstall": "patch-package && node post-install-setup.js", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
patch-package
is used for patching files in the node_modules
directory (see patches
directory)
Co-authored-by: Timo Glastra <timo@animo.id> Signed-off-by: Clécio Varjão <1348549+cvarjao@users.noreply.github.com>
Co-authored-by: Timo Glastra <timo@animo.id> Signed-off-by: Clécio Varjão <1348549+cvarjao@users.noreply.github.com>
I think this issue has gone stale. We can re-introduce it once we get the Indy SDK for Apple Silicon tested and in the bag. |
…cred-failure fix Person cred test gmail invite handling
Summary of Changes
Externalize dependency for indy-sdk-react-native (android)
Related Issues
N/A
Pull Request Checklist
This is just a reminder about the most common mistakes. Please make sure that you tick all appropriate boxes. But please read our contribution guide at least once; it will save you a few review cycles!
If an item doesn't apply to your pull request, check it anyway to make it apparent that there's nothing to do.
Signed-off-by
line (we use the DCO GitHub app to enforce this).npm run style-format
If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!
PR template adapted from the Python attrs project.