Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move vdrtools fork under aries-vcx repo #724

Closed
Patrik-Stas opened this issue Jan 7, 2023 · 2 comments · Fixed by #732
Closed

Move vdrtools fork under aries-vcx repo #724

Patrik-Stas opened this issue Jan 7, 2023 · 2 comments · Fixed by #732
Assignees

Comments

@Patrik-Stas
Copy link
Contributor

Patrik-Stas commented Jan 7, 2023

I'd like to suggest moving the fork of vdr-tools into this repo. We currently using fork of vdrtools, eg:
https://github.com/hyperledger/aries-vcx/blob/0.50.0/aries_vcx/Cargo.toml#L40

Given good developments toward credex libs migration and commitment to drop usage of libindy/vdrtools in 2023, in combo with the fact there's no updates for the library from Evernym https://gitlab.com/evernym/verity/vdr-tools I think we can continue taking lead within our fork, but move the development here, rather than having it externalized and less transparent on some gitlab repo.

As underlying code for holder, prover, verifier works with credex libraries, large portions of the vdr-tools codebase can technically be deleted today (with some updates to libvcx codebase to start using credex/indy-vdr codepaths by default). By the end of the journey, the only thing which should be left out of vdrtools is wallet implementation, which might be then superseded (or might be used interchangeably) by (or with) Aries Askar.

Additionally having git dependency would become a problem once we attempt to publish aries-vcx as crate (this was touched on at the last aries-vcx call)

@mirgee @gmulhearn what do you think?

@Patrik-Stas Patrik-Stas changed the title Proposal: Fork vdrtools Proposal: Fork vdrtools under aries-vcx repo Jan 7, 2023
@Patrik-Stas Patrik-Stas changed the title Proposal: Fork vdrtools under aries-vcx repo Proposal: Move vdrtools fork under aries-vcx repo Jan 7, 2023
@gmulhearn
Copy link
Contributor

No immediate issues come to mind - could be a good move if the plan is to move away from vdrtools. Will be convenient with some of the dependency issues we know we'll likely have to solve.

I'd be interested to see how IDEs perform with this change. I wonder if it will impact performance having the giant vdrtools repo 'open' at all times when working in the aries-vcx workspace?

@Patrik-Stas
Copy link
Contributor Author

Patrik-Stas commented Jan 9, 2023

I am confident M1 users won't notice ;-) But on slower machines, I guess depends on IDE, both performance and possible solutions. in InteliJ for example you can exclude directory from being indexed. Not sure if users of other IDEs might run into an issue.

@mirgee mirgee self-assigned this Jan 11, 2023
@mirgee mirgee changed the title Proposal: Move vdrtools fork under aries-vcx repo Move vdrtools fork under aries-vcx repo Jan 11, 2023
@mirgee mirgee linked a pull request Jan 11, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants