Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log rejected blocks at INFO level #1412

Closed
timbeiko opened this issue Oct 1, 2020 · 0 comments
Closed

Log rejected blocks at INFO level #1412

timbeiko opened this issue Oct 1, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@timbeiko
Copy link
Contributor

timbeiko commented Oct 1, 2020

Besu rejected a block on mainnet and the top-level logs didn't make that clear. When we reject a block, we should surface the lower-level logs so that users running Besu with the default logging options see the block has been rejected.

Context on the specific rejected block was shared in the AllCoreDevs discord.

Note from @shemnon:

Besu is reporting it via debug_getBadBlocks, however our validation errors currently log below INFO (at DEBUG and TRACE)
@timbeiko timbeiko added the enhancement New feature or request label Oct 1, 2020
@timbeiko timbeiko changed the title Better logging for rejected blocks Log rejected blocks at INFO level Oct 1, 2020
@shemnon shemnon mentioned this issue Oct 2, 2020
Merged
1 task
@timbeiko timbeiko closed this as completed Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@timbeiko