Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

custom factories for PicoCLI subcommands #3584

Open
macfarla opened this issue Mar 15, 2022 · 0 comments
Open

custom factories for PicoCLI subcommands #3584

macfarla opened this issue Mar 15, 2022 · 0 comments
Labels
good first issue Good for newcomers

Comments

@macfarla
Copy link
Contributor

Probably for another time, but it may be worth trying to remove explicit subcommands instantiation, setup proper factories for those classes and then set the subcommands field in the BesuCommand class with INHERIT scope. That way we won't need to explicitly set the versionProvider and mixinStandardHelpOptions everywhere (ref: remkop/picocli#1164)

As per comments on this PR:
#3577
@macfarla macfarla added the good first issue Good for newcomers label Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@macfarla