Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fcU: Ignore if newHead references an ancestor of chain head #4051

Closed
daniellehrner opened this issue Jul 4, 2022 · 0 comments · Fixed by #4055
Closed

fcU: Ignore if newHead references an ancestor of chain head #4051

daniellehrner opened this issue Jul 4, 2022 · 0 comments · Fixed by #4055
Assignees
@daniellehrner
Labels
mainnet

Comments

@daniellehrner
Copy link
Contributor

Description

The spec says:

Client software MAY skip an update of the forkchoice state and MUST NOT begin a payload build process if forkchoiceState.headBlockHash references an ancestor of the head of canonical chain. In the case of such an event, client software MUST return {payloadStatus: {status: VALID, latestValidHash: forkchoiceState.headBlockHash, validationError: null}, payloadId: null}.

Right now we are rolling back the chain if we receive an ancestor of our chain head. We need to check if the newHead is indeed an ancestor of chain head and ignore the update in such a case.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daniellehrner daniellehrner

Labels
mainnet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fcU: Ignore newHead if it is an ancestor of chain head daniellehrner/besu
1 participant
@daniellehrner