RLP zero encoding fix. #4388
Merged
RLP zero encoding fix. #4388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mark-terry <mark.terry@consensys.net>
Signed-off-by: mark-terry <mark.terry@consensys.net>
Signed-off-by: mark-terry <mark.terry@consensys.net>
Signed-off-by: mark-terry <mark.terry@consensys.net>
|
22.7.2 has been fix it |
Signed-off-by: mark-terry <mark.terry@consensys.net>
Signed-off-by: mark-terry <mark.terry@consensys.net>
pinges
approved these changes
Sep 21, 2022
ethereum/rlp/src/main/java/org/hyperledger/besu/ethereum/rlp/RLPOutput.java
Outdated
Show resolved
Hide resolved
Signed-off-by: mark-terry <36909937+mark-terry@users.noreply.github.com>
macfarla
reviewed
Oct 6, 2022
Signed-off-by: mark-terry <mark.terry@consensys.net>
pinges
reviewed
Oct 6, 2022
| @@ -187,7 +188,7 @@ default void writeLong(final long l) { | |||
| * {@code b < 0} or {@code b > 0xFF}. | |||
| */ | |||
| default void writeUnsignedByte(final int b) { | |||
| writeBytes(Bytes.of(b)); | |||
| processZeroByte(Long.valueOf(b), a -> writeBytes(Bytes.of(b))); | |||
There was a problem hiding this comment.
As b is an integer, could Bytes.of(b) be more than one byte long? With the other writeUnsignedXXX we are making sure that there aren't more bytes than we want (e.g. Bytes.ofUnsignedShort in writeUnsignedShort). Do we have to do something similar here as well?
There was a problem hiding this comment.
Within Bytes.of() there's a check to confirm whether the value fits within a byte, which throws an IllegalArgumentException if the value would be truncated.
Signed-off-by: mark-terry <mark.terry@consensys.net>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
* RLP zero encoding fix. Signed-off-by: mark-terry <mark.terry@consensys.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: mark-terry mark.terry@consensys.net
PR description
Updates the RLPOutput encoding to encode 0 as 0x80
Fixed Issue(s)
Fixes #4284
Documentation
doc-change-requiredlabel to this PR ifupdates are required.
Changelog