Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DCO Check Github Action #4837

Open
siladu opened this issue Dec 19, 2022 · 5 comments · Fixed by #4847
Open

Fix DCO Check Github Action #4837

siladu opened this issue Dec 19, 2022 · 5 comments · Fixed by #4847
Labels
dev experience The build system, things that enable easier development etc.

Comments

@siladu
Copy link
Contributor

siladu commented Dec 19, 2022

It appears that when the DCO check was moved from Circle CI to Github Action, it no longer picked up DCO failure on the main branch itself.
@macfarla macfarla mentioned this issue Dec 20, 2022
Merged
2 tasks
@macfarla
Copy link
Contributor

rolled back in #4855

@macfarla macfarla reopened this Dec 21, 2022
@macfarla macfarla mentioned this issue Dec 21, 2022
Closed
2 tasks
@non-fungible-nelson
Copy link
Contributor

@macfarla - not fixed correct?

@non-fungible-nelson non-fungible-nelson added the dev experience The build system, things that enable easier development etc. label Jan 26, 2023
@macfarla
Copy link
Contributor

correct. DCO on main branch is not prevented by the DCO checks we are running. it happens rarely but would be good to prevent this

@siladu
Copy link
Contributor Author

siladu commented Mar 3, 2023

@non-fungible-nelson why did you close? This isn't completed.

@macfarla macfarla mentioned this issue Mar 13, 2023
Closed
@macfarla
Copy link
Contributor

The current DCO app that we use doesn't support the merge event trigger.

I tried it out here https://github.com/daisy-row/vigilant-octo-umbrella/pull/18
and you can see the DCO job fail here https://github.com/daisy-row/vigilant-octo-umbrella/actions/runs/4409849241/jobs/7726648239
with Unexpected end of JSON input
which comes from https://github.com/tim-actions/get-pr-commits/blob/master/index.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dev experience The build system, things that enable easier development etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

DCO check on main macfarla/besu
alternate dco that can run on push to branch macfarla/besu
3 participants
@macfarla @siladu @non-fungible-nelson