This repository has been archived by the owner on May 13, 2022. It is now read-only.
enable abi encoding / decoding of structs as function params #1285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gregory Hill <gregorydhill@outlook.com>
|
Looking at the code, I'm not sure this will work with structs-in-structs. Some test cases for struct-in-struct, fixed length array of struct, and dynamic length array of struct would be useful. Both encode/decode. |
seanyoung
suggested changes
Mar 10, 2021
There was a problem hiding this comment.
The encoding of structs with fixed-length fields, and dynamic length fields differs significantly. This is also true for arrays of struct (array of struct with fixed length fields and one with dynamic length fields.
All these cases need testcases and implementation.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Gregory Hill greg.hill@monax.io