Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: custom check for package module,main,types,etc. #1644

Open
petermetz opened this issue Dec 8, 2021 · 1 comment
Open

ci: custom check for package module,main,types,etc. #1644

petermetz opened this issue Dec 8, 2021 · 1 comment
Labels
dependencies Pull requests that update a dependency file Developer_Experience enhancement New feature or request good-first-issue Good for newcomers good-first-issue-400-expert Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label. P4 Priority 4: Low

Comments

@petermetz
Copy link
Member

Right now there is no automated check to verify that the main, types and module properties in the package.json files of packages of the monorepo are set up as they should be and this can lead to situations where maintainers miss these mistakes and then approve packages that are not actually working in terms of the build of the whole repo.

There should be a check that makes this a non-issue by enforcing it within the CI.

@petermetz petermetz added dependencies Pull requests that update a dependency file Developer_Experience enhancement New feature or request good-first-issue Good for newcomers good-first-issue-400-expert Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label. P4 Priority 4: Low labels Dec 8, 2021
@Leeyoungone
Copy link
Contributor

Hey @petermetz, I'd love to create a automated check for this issue and I was wondering if you could tell me more about it. I know that the monorepo is where code for multiple projects are stored in the same repository. Sorry if this is an obvious question but which parts of cactus is the monorepo?

situations where maintainers miss these mistakes and then approve packages

When you mention packages here, do you mean a package such as cactus-plugin-ledger-connector-besu?

maintainers miss these mistakes and then approve packages that are not actually working in terms of the build of the whole repo.

I feel as though that this is already being checked by the CI build themselves? If we are adding packages doesn't the CI build for node-14 and node-16 already see if the approved packages are compatible for the while repo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file Developer_Experience enhancement New feature or request good-first-issue Good for newcomers good-first-issue-400-expert Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label. P4 Priority 4: Low
Projects
None yet
Development

No branches or pull requests

2 participants