fix(odap-plugin): fix bug in #2198 #2205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreAugusto11
requested review from
petermetz,
takeutak,
izuru0,
jagpreetsinghsasan and
sandeepnRES
as code owners
AndreAugusto11
force-pushed
the
fix-odap-plugin-knex-bug
branch
3 times, most recently
from
74dfb08
to
9ac7651
Compare
takeutak
approved these changes
Nov 14, 2022
AndreAugusto11
force-pushed
the
fix-odap-plugin-knex-bug
branch
from
9ac7651
to
70b3391
Compare
|
@petermetz the |
petermetz
requested changes
Nov 15, 2022
There was a problem hiding this comment.
@AndreAugusto11 LGTM on the code diff but please make sure to have the commit message contain at least the same level of information as the PR description answering the What/Why questions in general.
Also make sure to use the Fixes #??? syntax both in the PR description and in the commit message to signify that this PR is fixing the specific issue and have GitHub auto-close it for us (otherwise someone manually has to hunt down the issue itself and close it)
AndreAugusto11
force-pushed
the
fix-odap-plugin-knex-bug
branch
3 times, most recently
from
56ecd88
to
81714ce
Compare
AndreAugusto11
requested review from
petermetz
and removed request for
sandeepnRES,
jagpreetsinghsasan and
izuru0
petermetz
approved these changes
Nov 20, 2022
… same database * getLogsMoreRecentThanTimestamp() was returning more logs than supposed because * both gateways were using the same database, instead of each having its own Signed-off-by: André Augusto <andre.augusto@tecnico.ulisboa.pt>
petermetz
force-pushed
the
fix-odap-plugin-knex-bug
branch
from
81714ce
to
7c3708f
Compare
AndreAugusto11
added a commit
to AndreAugusto11/cacti
that referenced
this pull request
Nov 22, 2022
This application demonstrates a CBDC bridging between a Fabric and a Besu network using the ODAP business logic plugin, a protocol under standardization for cross-chain asset transfers in the IETF. The goal is to demonstrate the use of npm packages of Cactus so that anyone can build a solution on top of Cacti. Summary: * CBDC application backend (set up underlying ledgers and deployment of smart contracts) * Add support for multiple organizations in some operations in the FabricTestLedger * Add support for minting some Ether to a given address in the BesuTestLedger Future Work: * CBDC app UI demonstrating the use of the app is, for now, only available as docker image * A Dockerfile for the backend will be created as soon as this package is published to npm * More documentation will be added in the next weeks Dependent on hyperledger#2205 Signed-off-by: André Augusto <andre.augusto@tecnico.ulisboa.pt>
AndreAugusto11
added a commit
to AndreAugusto11/cacti
that referenced
this pull request
Dec 18, 2022
This application demonstrates a CBDC bridging between a Fabric and a Besu network using the ODAP business logic plugin, a protocol under standardization for cross-chain asset transfers in the IETF. The goal is to demonstrate the use of npm packages of Cactus so that anyone can build a solution on top of Cacti. Summary: * CBDC application backend (set up underlying ledgers and deployment of smart contracts) * Add support for multiple organizations in some operations in the FabricTestLedger * Add support for minting some Ether to a given address in the BesuTestLedger Future Work: * CBDC app UI demonstrating the use of the app is, for now, only available as docker image * A Dockerfile for the backend will be created as soon as this package is published to npm * More documentation will be added in the next weeks Depends on: hyperledger#2205 Signed-off-by: André Augusto <andre.augusto@tecnico.ulisboa.pt>
AndreAugusto11
added a commit
to AndreAugusto11/cacti
that referenced
this pull request
Dec 18, 2022
This application demonstrates a CBDC bridging between a Fabric and a Besu network using the ODAP business logic plugin, a protocol under standardization for cross-chain asset transfers in the IETF. The goal is to demonstrate the use of npm packages of Cactus so that anyone can build a solution on top of Cacti. Summary: * CBDC application backend (set up underlying ledgers and deployment of smart contracts) * Add support for multiple organizations in some operations in the FabricTestLedger * Add support for minting some Ether to a given address in the BesuTestLedger Future Work: * CBDC app UI demonstrating the use of the app is, for now, only available as docker image * A Dockerfile for the backend will be created as soon as this package is published to npm * More documentation will be added in the next weeks Depends on: hyperledger#2205 Signed-off-by: André Augusto <andre.augusto@tecnico.ulisboa.pt>
AndreAugusto11
added a commit
to AndreAugusto11/cacti
that referenced
this pull request
Dec 18, 2022
This application demonstrates a CBDC bridging between a Fabric and a Besu network using the ODAP business logic plugin, a protocol under standardization for cross-chain asset transfers in the IETF. The goal is to demonstrate the use of npm packages of Cactus so that anyone can build a solution on top of Cacti. Summary: * CBDC application backend (set up underlying ledgers and deployment of smart contracts) * Add support for multiple organizations in some operations in the FabricTestLedger * Add support for minting some Ether to a given address in the BesuTestLedger Future Work: * CBDC app UI demonstrating the use of the app is, for now, only available as docker image * A Dockerfile for the backend will be created as soon as this package is published to npm * More documentation will be added in the next weeks Depends on: hyperledger#2205 Signed-off-by: André Augusto <andre.augusto@tecnico.ulisboa.pt>
AndreAugusto11
added a commit
to AndreAugusto11/cacti
that referenced
this pull request
Jan 8, 2023
This application demonstrates a CBDC bridging between a Fabric and a Besu network using the ODAP business logic plugin, a protocol under standardization for cross-chain asset transfers in the IETF. The goal is to demonstrate the use of npm packages of Cactus so that anyone can build a solution on top of Cacti. Summary: * CBDC application backend (set up underlying ledgers and deployment of smart contracts) * Add support for multiple organizations in some operations in the FabricTestLedger * Add support for minting some Ether to a given address in the BesuTestLedger Future Work: * CBDC app UI demonstrating the use of the app is, for now, only available as docker image * A Dockerfile for the backend will be created as soon as this package is published to npm * More documentation will be added in the next weeks Depends on: hyperledger#2205 Signed-off-by: André Augusto <andre.augusto@tecnico.ulisboa.pt>
AndreAugusto11
added a commit
to AndreAugusto11/cacti
that referenced
this pull request
Jan 8, 2023
This application demonstrates a CBDC bridging between a Fabric and a Besu network using the ODAP business logic plugin, a protocol under standardization for cross-chain asset transfers in the IETF. The goal is to demonstrate the use of npm packages of Cactus so that anyone can build a solution on top of Cacti. Summary: * CBDC application backend (set up underlying ledgers and deployment of smart contracts) * Add support for multiple organizations in some operations in the FabricTestLedger * Add support for minting some Ether to a given address in the BesuTestLedger Future Work: * CBDC app UI demonstrating the use of the app is, for now, only available as docker image * A Dockerfile for the backend will be created as soon as this package is published to npm * More documentation will be added in the next weeks Depends on: hyperledger#2205 Signed-off-by: André Augusto <andre.augusto@tecnico.ulisboa.pt>
petermetz
pushed a commit
to AndreAugusto11/cacti
that referenced
this pull request
Aug 16, 2023
This application demonstrates a CBDC bridging between a Fabric and a Besu network using the ODAP business logic plugin, a protocol under standardization for cross-chain asset transfers in the IETF. The goal is to demonstrate the use of npm packages of Cactus so that anyone can build a solution on top of Cacti. Summary: * CBDC application backend (set up underlying ledgers and deployment of smart contracts) * Add support for multiple organizations in some operations in the FabricTestLedger * Add support for minting some Ether to a given address in the BesuTestLedger Future Work: * CBDC app UI demonstrating the use of the app is, for now, only available as docker image * A Dockerfile for the backend will be created as soon as this package is published to npm * More documentation will be added in the next weeks Depends on: hyperledger#2205 Co-authored-by: Peter Somogyvari <peter.somogyvari@accenture.com> Signed-off-by: André Augusto <andre.augusto@tecnico.ulisboa.pt> Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
AndreAugusto11
added a commit
to AndreAugusto11/cacti
that referenced
this pull request
Aug 16, 2023
This application demonstrates a CBDC bridging between a Fabric and a Besu network using the ODAP business logic plugin, a protocol under standardization for cross-chain asset transfers in the IETF. The goal is to demonstrate the use of npm packages of Cactus so that anyone can build a solution on top of Cacti. Summary: * CBDC application backend (set up underlying ledgers and deployment of smart contracts) * Add support for multiple organizations in some operations in the FabricTestLedger * Add support for minting some Ether to a given address in the BesuTestLedger Future Work: * CBDC app UI demonstrating the use of the app is, for now, only available as docker image * A Dockerfile for the backend will be created as soon as this package is published to npm * More documentation will be added in the next weeks Depends on: hyperledger#2205 Co-authored-by: Peter Somogyvari <peter.somogyvari@accenture.com> Signed-off-by: André Augusto <andre.augusto@tecnico.ulisboa.pt> Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
AndreAugusto11
added a commit
to AndreAugusto11/cacti
that referenced
this pull request
Aug 16, 2023
This application demonstrates a CBDC bridging between a Fabric and a Besu network using the ODAP business logic plugin, a protocol under standardization for cross-chain asset transfers in the IETF. The goal is to demonstrate the use of npm packages of Cactus so that anyone can build a solution on top of Cacti. Summary: * CBDC application backend (set up underlying ledgers and deployment of smart contracts) * Add support for multiple organizations in some operations in the FabricTestLedger * Add support for minting some Ether to a given address in the BesuTestLedger Future Work: * CBDC app UI demonstrating the use of the app is, for now, only available as docker image * A Dockerfile for the backend will be created as soon as this package is published to npm * More documentation will be added in the next weeks Depends on: hyperledger#2205 Co-authored-by: Peter Somogyvari <peter.somogyvari@accenture.com> Signed-off-by: André Augusto <andre.augusto@tecnico.ulisboa.pt> Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
AndreAugusto11
added a commit
to AndreAugusto11/cacti
that referenced
this pull request
Aug 16, 2023
This application demonstrates a CBDC bridging between a Fabric and a Besu network using the ODAP business logic plugin, a protocol under standardization for cross-chain asset transfers in the IETF. The goal is to demonstrate the use of npm packages of Cactus so that anyone can build a solution on top of Cacti. Summary: * CBDC application backend (set up underlying ledgers and deployment of smart contracts) * Add support for multiple organizations in some operations in the FabricTestLedger * Add support for minting some Ether to a given address in the BesuTestLedger Future Work: * CBDC app UI demonstrating the use of the app is, for now, only available as docker image * A Dockerfile for the backend will be created as soon as this package is published to npm * More documentation will be added in the next weeks Depends on: hyperledger#2205 Co-authored-by: Peter Somogyvari <peter.somogyvari@accenture.com> Signed-off-by: André Augusto <andre.augusto@tecnico.ulisboa.pt> Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz
pushed a commit
to AndreAugusto11/cacti
that referenced
this pull request
Aug 16, 2023
This application demonstrates a CBDC bridging between a Fabric and a Besu network using the ODAP business logic plugin, a protocol under standardization for cross-chain asset transfers in the IETF. The goal is to demonstrate the use of npm packages of Cactus so that anyone can build a solution on top of Cacti. Summary: * CBDC application backend (set up underlying ledgers and deployment of smart contracts) * Add support for multiple organizations in some operations in the FabricTestLedger * Add support for minting some Ether to a given address in the BesuTestLedger Future Work: * CBDC app UI demonstrating the use of the app is, for now, only available as docker image * A Dockerfile for the backend will be created as soon as this package is published to npm * More documentation will be added in the next weeks Depends on: hyperledger#2205 Co-authored-by: Peter Somogyvari <peter.somogyvari@accenture.com> Signed-off-by: André Augusto <andre.augusto@tecnico.ulisboa.pt> Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz
pushed a commit
to AndreAugusto11/cacti
that referenced
this pull request
Aug 17, 2023
This application demonstrates a CBDC bridging between a Fabric and a Besu network using the ODAP business logic plugin, a protocol under standardization for cross-chain asset transfers in the IETF. The goal is to demonstrate the use of npm packages of Cactus so that anyone can build a solution on top of Cacti. Summary: * CBDC application backend (set up underlying ledgers and deployment of smart contracts) * Add support for multiple organizations in some operations in the FabricTestLedger * Add support for minting some Ether to a given address in the BesuTestLedger Future Work: * CBDC app UI demonstrating the use of the app is, for now, only available as docker image * A Dockerfile for the backend will be created as soon as this package is published to npm * More documentation will be added in the next weeks Depends on: hyperledger#2205 Co-authored-by: Peter Somogyvari <peter.somogyvari@accenture.com> Signed-off-by: André Augusto <andre.augusto@tecnico.ulisboa.pt> Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz
pushed a commit
that referenced
this pull request
Aug 17, 2023
This application demonstrates a CBDC bridging between a Fabric and a Besu network using the ODAP business logic plugin, a protocol under standardization for cross-chain asset transfers in the IETF. The goal is to demonstrate the use of npm packages of Cactus so that anyone can build a solution on top of Cacti. Summary: * CBDC application backend (set up underlying ledgers and deployment of smart contracts) * Add support for multiple organizations in some operations in the FabricTestLedger * Add support for minting some Ether to a given address in the BesuTestLedger Future Work: * CBDC app UI demonstrating the use of the app is, for now, only available as docker image * A Dockerfile for the backend will be created as soon as this package is published to npm * More documentation will be added in the next weeks Depends on: #2205 Co-authored-by: Peter Somogyvari <peter.somogyvari@accenture.com> Signed-off-by: André Augusto <andre.augusto@tecnico.ulisboa.pt> Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
sandeepnRES
pushed a commit
to sandeepnRES/cacti
that referenced
this pull request
Dec 21, 2023
This application demonstrates a CBDC bridging between a Fabric and a Besu network using the ODAP business logic plugin, a protocol under standardization for cross-chain asset transfers in the IETF. The goal is to demonstrate the use of npm packages of Cactus so that anyone can build a solution on top of Cacti. Summary: * CBDC application backend (set up underlying ledgers and deployment of smart contracts) * Add support for multiple organizations in some operations in the FabricTestLedger * Add support for minting some Ether to a given address in the BesuTestLedger Future Work: * CBDC app UI demonstrating the use of the app is, for now, only available as docker image * A Dockerfile for the backend will be created as soon as this package is published to npm * More documentation will be added in the next weeks Depends on: hyperledger#2205 Co-authored-by: Peter Somogyvari <peter.somogyvari@accenture.com> Signed-off-by: André Augusto <andre.augusto@tecnico.ulisboa.pt> Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two gateways were using the same database, which was causing a test to fail.
When retrieving the logs since a certain timestamp, there were logs from the other gateway. This caused the number of logs retrieved to be higher than what was supposed to be.
Fixes #2198
Signed-off-by: André Augusto andre.augusto@tecnico.ulisboa.pt